| Message ID | 20230411130446.401440-1-brgl@bgdev.pl |
|---|---|
| Headers | show |
| Series | arm64: qcom: sa8775p: add support for UFS | expand |
On 11-04-23, 15:04, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add a new compatible for the QMP UFS PHY found on sa8775p platforms and > update the clocks property to accommodate three clocks. Applied, thanks
On 11.04.2023 15:04, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Enable the UFS and its PHY on sa8775p-ride. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > index f238a02a5448..2bb001a3ea55 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > @@ -5,6 +5,7 @@ > > /dts-v1/; > > +#include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > > #include "sa8775p.dtsi" > @@ -20,6 +21,7 @@ aliases { > serial2 = &uart17; > i2c18 = &i2c18; > spi16 = &spi16; > + ufshc1 = &ufs_mem_hc; > }; > > chosen { > @@ -426,6 +428,23 @@ &uart17 { > status = "okay"; > }; > > +&ufs_mem_hc { > + reset-gpios = <&tlmm 149 GPIO_ACTIVE_LOW>; > + vcc-supply = <&vreg_l8a>; > + vcc-max-microamp = <1100000>; > + vccq-supply = <&vreg_l4c>; > + vccq-max-microamp = <1200000>; > + > + status = "okay"; > +}; > + > +&ufs_mem_phy { > + vdda-phy-supply = <&vreg_l4a>; > + vdda-pll-supply = <&vreg_l1c>; > + > + status = "okay"; > +}; > + > &xo_board_clk { > clock-frequency = <38400000>; > };
On Tue, 11 Apr 2023 15:04:41 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Update relevant DT bindings, add new config to the driver and add UFS > and PHY nodes to the .dtsi and enable them in the board .dts for > sa8775p-ride. > > v2 -> v3: > - fix DT bindings: move allOf: below required: > - collect review tags > > [...] Applied, thanks! [4/5] arm64: dts: qcom: sa8775p: add UFS nodes commit: be543efeee17b93edaac61e49c6361d2209bd3d3 [5/5] arm64: dts: qcom: sa8775p-ride: enable UFS commit: 35c45a1125fc0772b95aa41acc25deddcf5492be Best regards,
On Tue, Apr 11, 2023 at 3:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add the compatible string for the UFS on sa8775p platforms. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index c5a06c048389..b1c00424c2b0 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -26,6 +26,7 @@ properties: > - qcom,msm8994-ufshc > - qcom,msm8996-ufshc > - qcom,msm8998-ufshc > + - qcom,sa8775p-ufshc > - qcom,sc8280xp-ufshc > - qcom,sdm845-ufshc > - qcom,sm6350-ufshc > @@ -105,6 +106,7 @@ allOf: > contains: > enum: > - qcom,msm8998-ufshc > + - qcom,sa8775p-ufshc > - qcom,sc8280xp-ufshc > - qcom,sm8250-ufshc > - qcom,sm8350-ufshc > -- > 2.37.2 > Bjorn, Are you picking this one up as well or should it go through Rob's tree? Bart
Bartosz, > Hey UFS maintainers, could you please pick this one up for the next > merge window? Applied to 6.5/scsi-staging, thanks!
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Update relevant DT bindings, add new config to the driver and add UFS and PHY nodes to the .dtsi and enable them in the board .dts for sa8775p-ride. v2 -> v3: - fix DT bindings: move allOf: below required: - collect review tags v1 -> v2: - order new compatibles alphabetically - rework the UFS PHY bindings to accomodate more clocks - add a comment in the .dts regarding a non-standard clock used by the UFS PHY Bartosz Golaszewski (5): dt-bindings: ufs: qcom: add compatible for sa8775p dt-bindings: phy: qmp-ufs: describe the UFS PHY for sa8775p phy: qualcomm: phy-qcom-qmp-ufs: add definitions for sa8775p arm64: dts: qcom: sa8775p: add UFS nodes arm64: dts: qcom: sa8775p-ride: enable UFS .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 26 ++++++++- .../devicetree/bindings/ufs/qcom,ufs.yaml | 2 + arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 19 ++++++ arch/arm64/boot/dts/qcom/sa8775p.dtsi | 58 +++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 38 ++++++++++++ 5 files changed, 142 insertions(+), 1 deletion(-)