| Message ID | d4218947e354aee45589acb1060ce41727a26750.1681646904.git.jahau@rocketmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add RT5033 charger device driver | expand |
Hi Krzysztof, On 16.04.23 20:32, Krzysztof Kozlowski wrote: > On 16/04/2023 14:44, Jakob Hauser wrote: >> Lowercase is preferred for node names. > > This will break all existing users. In-tree and out-of-tree. Where is > the binding update? In my reply to Rob's comments in v1 I was pointing out that this will affect an existing driver. There was no reaction. As far as I can see, there is no in-tree usage yet. Though I can't tell about out-of-tree usage. Although if there is, adding the rt5033-charger driver might already causes the need for changes. Well, to stay on the safe side, I'll drop this patch in v3 and will change the bindings (patch 9) back to uppercase. Kind regards, Jakob
On 18/04/2023 23:24, Jakob Hauser wrote: > Hi Krzysztof, > > On 16.04.23 20:32, Krzysztof Kozlowski wrote: >> On 16/04/2023 14:44, Jakob Hauser wrote: >>> Lowercase is preferred for node names. >> >> This will break all existing users. In-tree and out-of-tree. Where is >> the binding update? > > In my reply to Rob's comments in v1 I was pointing out that this will > affect an existing driver. There was no reaction. > > As far as I can see, there is no in-tree usage yet. Though I can't tell > about out-of-tree usage. Although if there is, adding the rt5033-charger > driver might already causes the need for changes. > > Well, to stay on the safe side, I'll drop this patch in v3 and will > change the bindings (patch 9) back to uppercase. > Your v1 binding patch did not explain that you document existing ABI, so you got comments like for a new binding. This is not really new binding, is it? Best regards, Krzysztof
diff --git a/drivers/regulator/rt5033-regulator.c b/drivers/regulator/rt5033-regulator.c index 2ba74f205543..dee272dc81df 100644 --- a/drivers/regulator/rt5033-regulator.c +++ b/drivers/regulator/rt5033-regulator.c @@ -41,8 +41,8 @@ static const struct regulator_ops rt5033_buck_ops = { static const struct regulator_desc rt5033_supported_regulators[] = { [RT5033_BUCK] = { - .name = "BUCK", - .of_match = of_match_ptr("BUCK"), + .name = "buck", + .of_match = of_match_ptr("buck"), .regulators_node = of_match_ptr("regulators"), .id = RT5033_BUCK, .ops = &rt5033_buck_ops, @@ -57,8 +57,8 @@ static const struct regulator_desc rt5033_supported_regulators[] = { .vsel_mask = RT5033_BUCK_CTRL_MASK, }, [RT5033_LDO] = { - .name = "LDO", - .of_match = of_match_ptr("LDO"), + .name = "ldo", + .of_match = of_match_ptr("ldo"), .regulators_node = of_match_ptr("regulators"), .id = RT5033_LDO, .ops = &rt5033_buck_ops, @@ -73,8 +73,8 @@ static const struct regulator_desc rt5033_supported_regulators[] = { .vsel_mask = RT5033_LDO_CTRL_MASK, }, [RT5033_SAFE_LDO] = { - .name = "SAFE_LDO", - .of_match = of_match_ptr("SAFE_LDO"), + .name = "safe_ldo", + .of_match = of_match_ptr("safe_ldo"), .regulators_node = of_match_ptr("regulators"), .id = RT5033_SAFE_LDO, .ops = &rt5033_safe_ldo_ops,
Lowercase is preferred for node names. Cc: Beomho Seo <beomho.seo@samsung.com> Cc: Chanwoo Choi <cw00.choi@samsung.com> Cc: Axel Lin <axel.lin@ingics.com> Cc: ChiYuan Huang <cy_huang@richtek.com> Signed-off-by: Jakob Hauser <jahau@rocketmail.com> --- drivers/regulator/rt5033-regulator.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)