| Message ID | 20230508160446.2374438-2-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: dts: qcom: apq8074-dragonboard: enable additional devices | expand |
On 8.05.2023 18:04, Dmitry Baryshkov wrote: > On PM8941 pon doesn't store the reset reason. However we still need the > wrapping node for pwrkey and resin nodes. Add bindings for pm8941-pon > device. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Should probably also disallow setting reboot modes! Konrad > Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > index d96170eecbd2..0f4f55dd4eac 100644 > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > @@ -19,6 +19,7 @@ properties: > compatible: > enum: > - qcom,pm8916-pon > + - qcom,pm8941-pon > - qcom,pms405-pon > - qcom,pm8998-pon > - qcom,pmk8350-pon > @@ -63,6 +64,7 @@ allOf: > contains: > enum: > - qcom,pm8916-pon > + - qcom,pm8941-pon > - qcom,pms405-pon > - qcom,pm8998-pon > then:
On Tue, 9 May 2023 at 11:53, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 8.05.2023 18:04, Dmitry Baryshkov wrote: > > On PM8941 pon doesn't store the reset reason. However we still need the > > wrapping node for pwrkey and resin nodes. Add bindings for pm8941-pon > > device. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > Should probably also disallow setting reboot modes! But we don't set reboot modes in DT! > > Konrad > > Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > > index d96170eecbd2..0f4f55dd4eac 100644 > > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > > @@ -19,6 +19,7 @@ properties: > > compatible: > > enum: > > - qcom,pm8916-pon > > + - qcom,pm8941-pon > > - qcom,pms405-pon > > - qcom,pm8998-pon > > - qcom,pmk8350-pon > > @@ -63,6 +64,7 @@ allOf: > > contains: > > enum: > > - qcom,pm8916-pon > > + - qcom,pm8941-pon > > - qcom,pms405-pon > > - qcom,pm8998-pon > > then:
On 9.05.2023 13:21, Dmitry Baryshkov wrote: > On Tue, 9 May 2023 at 11:53, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> >> >> On 8.05.2023 18:04, Dmitry Baryshkov wrote: >>> On PM8941 pon doesn't store the reset reason. However we still need the >>> wrapping node for pwrkey and resin nodes. Add bindings for pm8941-pon >>> device. >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >> Should probably also disallow setting reboot modes! > > But we don't set reboot modes in DT! That's what I'm saying :P > >> >> Konrad >>> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>> index d96170eecbd2..0f4f55dd4eac 100644 >>> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>> @@ -19,6 +19,7 @@ properties: >>> compatible: >>> enum: >>> - qcom,pm8916-pon >>> + - qcom,pm8941-pon >>> - qcom,pms405-pon >>> - qcom,pm8998-pon >>> - qcom,pmk8350-pon >>> @@ -63,6 +64,7 @@ allOf: >>> contains: >>> enum: >>> - qcom,pm8916-pon >>> + - qcom,pm8941-pon >>> - qcom,pms405-pon >>> - qcom,pm8998-pon >>> then: [...] allOf: - $ref: reboot-mode.yaml# Konrad > > >
diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml index d96170eecbd2..0f4f55dd4eac 100644 --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml @@ -19,6 +19,7 @@ properties: compatible: enum: - qcom,pm8916-pon + - qcom,pm8941-pon - qcom,pms405-pon - qcom,pm8998-pon - qcom,pmk8350-pon @@ -63,6 +64,7 @@ allOf: contains: enum: - qcom,pm8916-pon + - qcom,pm8941-pon - qcom,pms405-pon - qcom,pm8998-pon then: