Message ID | 20230315112829.165884-1-mmyangfl@gmail.com |
---|---|
State | New |
Headers | show |
Series | arm64: dts: hi3798cv200: Correct 'clock-names' in sd0 | expand |
On 15/03/2023 12:28, David Yang wrote: > "ciu" and "biu" were incorrectly swapped. Fix them to match 'clocks'. > > Signed-off-by: David Yang <mmyangfl@gmail.com> This breaks the bindings. You wanted probably different order. Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi index a83b9d4f1..7112f9933 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi @@ -304,7 +304,7 @@ sd0: mmc@9820000 { interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>; clocks = <&crg HISTB_SDIO0_CIU_CLK>, <&crg HISTB_SDIO0_BIU_CLK>; - clock-names = "biu", "ciu"; + clock-names = "ciu", "biu"; resets = <&crg 0x9c 4>; reset-names = "reset"; status = "disabled";
"ciu" and "biu" were incorrectly swapped. Fix them to match 'clocks'. Signed-off-by: David Yang <mmyangfl@gmail.com> --- arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)