mbox series

[v2,0/2] Add phy tuning support for imx8mq-usb

Message ID 20230516-lustige-usb-phy-dinge-v2-0-3383a0de34ac@pengutronix.de
Headers show
Series Add phy tuning support for imx8mq-usb | expand

Message

Johannes Zink May 16, 2023, 4:20 p.m. UTC
This series adds support for USB phy tuning parameters, which are
required for meeting USB certification and EMI qualification.

Patch 1/2 adds the required properties to the fsl,imx8mq-usb-phy
devicetree binding.

Patch 2/2 adds the phy tuning parameters to the phy-fsl-imx8mp driver.
This patch is ported and cleaned up from the downstream Freescale vendor
tree.

Best regards,
Johannes

Johannes Zink (1):
  dt-bindings: phy: imx8mq-usb: add phy tuning properties

Li Jun (1):
  phy: fsl-imx8mp-usb: add support for phy tuning

---

Changelog:

  v1 -> v2: worked in review from Krzysztof and Rob, thanks for your
  review:
   - extract more useful descriptions of the properties from the
     datasheet
   - use unit postfixes for the device tree properties to facilitate
     porting in the future
   - add more information about some of the properties (thanks to Li Jun
     for clarification)
   - adjust parsing of the devicetree properties in the driver to scale
     to the proper register values

Signed-off-by: Johannes Zink <j.zink@pengutronix.de>

---
Johannes Zink (1):
      dt-bindings: phy: imx8mq-usb: add phy tuning properties

Li Jun (1):
      phy: fsl-imx8mp-usb: add support for phy tuning

 .../bindings/phy/fsl,imx8mq-usb-phy.yaml           |  47 +++++
 drivers/phy/freescale/phy-fsl-imx8mq-usb.c         | 218 +++++++++++++++++++++
 2 files changed, 265 insertions(+)
---
base-commit: 7a503071e06db4409b7066b8ecca9f3da03dd3b1
change-id: 20230516-lustige-usb-phy-dinge-f8dfccb35bc5

Best regards,

Comments

Krzysztof Kozlowski May 17, 2023, 8:45 a.m. UTC | #1
On 16/05/2023 18:20, Johannes Zink wrote:
> Add optional properties for tuning of usb phy.
> 
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
> ---
>  .../bindings/phy/fsl,imx8mq-usb-phy.yaml           | 47 ++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Vinod Koul May 19, 2023, 5:50 p.m. UTC | #2
On 16-05-23, 18:20, Johannes Zink wrote:
> This series adds support for USB phy tuning parameters, which are
> required for meeting USB certification and EMI qualification.
> 
> Patch 1/2 adds the required properties to the fsl,imx8mq-usb-phy
> devicetree binding.
> 
> Patch 2/2 adds the phy tuning parameters to the phy-fsl-imx8mp driver.
> This patch is ported and cleaned up from the downstream Freescale vendor
> tree.

Applied, thanks