| Message ID | 20230529162034.20481-5-alexandre.torgue@foss.st.com |
|---|---|
| State | New |
| Headers | show |
| Series | [01/11] dt-bindings: pinctrl: stm32: support for stm32mp257 and additional packages | expand |
Hi Conor On 5/29/23 20:05, Conor Dooley wrote: > On Mon, May 29, 2023 at 06:20:27PM +0200, Alexandre Torgue wrote: >> STM32 family is extended by the addition of the STM32MP25 SoCs. It is composed >> of 4 SoCs: STM32MP251, STM32MP253, STM32MP255 and STM32MP257. >> >> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com> >> >> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >> index 4af5b8f4f803..7d7ca33d2e61 100644 >> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >> @@ -161,6 +161,15 @@ properties: >> - const: phytec,phycore-stm32mp157c-som >> - const: st,stm32mp157 >> >> + - items: >> + - const: st,stm32mp251 >> + - items: >> + - const: st,stm32mp253 >> + - items: >> + - const: st,stm32mp255 >> + - items: >> + - const: st,stm32mp257 > > I assume the slightly odd format is just to avoid churn when adding > the board compatibles. Yes, exactly. Alex > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor. > >> + >> additionalProperties: true >> >> ... >> -- >> 2.17.1 >>
Hi Krzysztof On 5/31/23 20:47, Krzysztof Kozlowski wrote: > On 30/05/2023 10:39, Alexandre TORGUE wrote: >> Hi Conor >> >> On 5/29/23 20:05, Conor Dooley wrote: >>> On Mon, May 29, 2023 at 06:20:27PM +0200, Alexandre Torgue wrote: >>>> STM32 family is extended by the addition of the STM32MP25 SoCs. It is composed >>>> of 4 SoCs: STM32MP251, STM32MP253, STM32MP255 and STM32MP257. >>>> >>>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com> >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>>> index 4af5b8f4f803..7d7ca33d2e61 100644 >>>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>>> @@ -161,6 +161,15 @@ properties: >>>> - const: phytec,phycore-stm32mp157c-som >>>> - const: st,stm32mp157 >>>> >>>> + - items: >>>> + - const: st,stm32mp251 >>>> + - items: >>>> + - const: st,stm32mp253 >>>> + - items: >>>> + - const: st,stm32mp255 >>>> + - items: >>>> + - const: st,stm32mp257 >>> >>> I assume the slightly odd format is just to avoid churn when adding >>> the board compatibles. >> >> Yes, exactly. >> > > I don't get it. How are you going to extend it? Or rather - what are you > documenting here? If these are SoCs, then this is not valid. We do not > allow these alone. > > No, please drop it. Ok. I will drop it in V2 and update binding patch which defines the STM32 EV1 board. Thanks Alex > > Best regards, > Krzysztof >
On 30/05/2023 10:39, Alexandre TORGUE wrote: > Hi Conor > > On 5/29/23 20:05, Conor Dooley wrote: >> On Mon, May 29, 2023 at 06:20:27PM +0200, Alexandre Torgue wrote: >>> STM32 family is extended by the addition of the STM32MP25 SoCs. It is composed >>> of 4 SoCs: STM32MP251, STM32MP253, STM32MP255 and STM32MP257. >>> >>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com> >>> >>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>> index 4af5b8f4f803..7d7ca33d2e61 100644 >>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>> @@ -161,6 +161,15 @@ properties: >>> - const: phytec,phycore-stm32mp157c-som >>> - const: st,stm32mp157 >>> >>> + - items: >>> + - const: st,stm32mp251 >>> + - items: >>> + - const: st,stm32mp253 >>> + - items: >>> + - const: st,stm32mp255 >>> + - items: >>> + - const: st,stm32mp257 >> >> I assume the slightly odd format is just to avoid churn when adding >> the board compatibles. > > Yes, exactly. > I don't get it. How are you going to extend it? Or rather - what are you documenting here? If these are SoCs, then this is not valid. We do not allow these alone. No, please drop it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml index 4af5b8f4f803..7d7ca33d2e61 100644 --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml @@ -161,6 +161,15 @@ properties: - const: phytec,phycore-stm32mp157c-som - const: st,stm32mp157 + - items: + - const: st,stm32mp251 + - items: + - const: st,stm32mp253 + - items: + - const: st,stm32mp255 + - items: + - const: st,stm32mp257 + additionalProperties: true ...
STM32 family is extended by the addition of the STM32MP25 SoCs. It is composed of 4 SoCs: STM32MP251, STM32MP253, STM32MP255 and STM32MP257. Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>