| Message ID | 1c40a12b51ccd6ee2ee002276f5b1ba92c377100.1687990098.git.objelf@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] Bluetooth: btmtk: add printing firmware information | expand |
Dear Sean, dear Chris, Thank you for your patch. Am 29.06.23 um 00:20 schrieb sean.wang@mediatek.com: > From: Chris Lu <chris.lu@mediatek.com> > > Add printing firmware information part when driver loading firmware that > user can get mediatek bluetooth information. Maybe use the commit message summary/title below: Bluetooth: btmtk: Log hw/sw version and fw build time Maybe also paste one log message example to the commit message. > Co-developed-by: Sean Wang <sean.wang@mediatek.com> > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > Signed-off-by: Chris Lu <chris.lu@mediatek.com> > --- > v3: resend again with the latest tree > --- > drivers/bluetooth/btmtk.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c > index 9482401d97fa..8490d59502a5 100644 > --- a/drivers/bluetooth/btmtk.c > +++ b/drivers/bluetooth/btmtk.c > @@ -57,6 +57,7 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname, > wmt_cmd_sync_func_t wmt_cmd_sync) > { > struct btmtk_hci_wmt_params wmt_params; > + struct btmtk_patch_header *hdr; > struct btmtk_global_desc *globaldesc = NULL; > struct btmtk_section_map *sectionmap; > const struct firmware *fw; > @@ -75,9 +76,13 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname, > > fw_ptr = fw->data; > fw_bin_ptr = fw_ptr; > + hdr = (struct btmtk_patch_header *)fw_ptr; > globaldesc = (struct btmtk_global_desc *)(fw_ptr + MTK_FW_ROM_PATCH_HEADER_SIZE); > section_num = le32_to_cpu(globaldesc->section_num); > > + bt_dev_info(hdev, "HW/SW Version: 0x%04x%04x, Build Time: %s", Why not print 0x%04x/0x%04x, that means with a slash? > + le16_to_cpu(hdr->hwver), le16_to_cpu(hdr->swver), hdr->datetime); > + > for (i = 0; i < section_num; i++) { > first_block = 1; > fw_ptr = fw_bin_ptr; Kind regards, Paul
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=761058 ---Test result--- Test Summary: CheckPatch PASS 0.61 seconds GitLint PASS 0.29 seconds SubjectPrefix PASS 0.10 seconds BuildKernel PASS 37.03 seconds CheckAllWarning PASS 34.78 seconds CheckSparse PASS 39.96 seconds CheckSmatch PASS 111.49 seconds BuildKernel32 PASS 30.79 seconds TestRunnerSetup PASS 438.73 seconds TestRunner_l2cap-tester PASS 16.62 seconds TestRunner_iso-tester PASS 22.39 seconds TestRunner_bnep-tester PASS 5.27 seconds TestRunner_mgmt-tester PASS 126.12 seconds TestRunner_rfcomm-tester PASS 8.42 seconds TestRunner_sco-tester PASS 7.77 seconds TestRunner_ioctl-tester PASS 8.99 seconds TestRunner_mesh-tester PASS 6.65 seconds TestRunner_smp-tester PASS 7.77 seconds TestRunner_userchan-tester PASS 5.51 seconds IncrementalBuild PASS 29.42 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 29 Jun 2023 06:20:03 +0800 you wrote: > From: Chris Lu <chris.lu@mediatek.com> > > Add printing firmware information part when driver loading firmware that > user can get mediatek bluetooth information. > > Co-developed-by: Sean Wang <sean.wang@mediatek.com> > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > Signed-off-by: Chris Lu <chris.lu@mediatek.com> > > [...] Here is the summary with links: - [v3] Bluetooth: btmtk: add printing firmware information https://git.kernel.org/bluetooth/bluetooth-next/c/5ebfb27d09e1 You are awesome, thank you!
HI Paul, Thanks! I will update the patch with your suggestions. thanks! Sean On Wed, Jun 28, 2023 at 3:44 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote: > > Dear Sean, dear Chris, > > > Thank you for your patch. > > Am 29.06.23 um 00:20 schrieb sean.wang@mediatek.com: > > From: Chris Lu <chris.lu@mediatek.com> > > > > Add printing firmware information part when driver loading firmware that > > user can get mediatek bluetooth information. > > Maybe use the commit message summary/title below: > > Bluetooth: btmtk: Log hw/sw version and fw build time > > Maybe also paste one log message example to the commit message. > > > Co-developed-by: Sean Wang <sean.wang@mediatek.com> > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > > Signed-off-by: Chris Lu <chris.lu@mediatek.com> > > --- > > v3: resend again with the latest tree > > --- > > drivers/bluetooth/btmtk.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c > > index 9482401d97fa..8490d59502a5 100644 > > --- a/drivers/bluetooth/btmtk.c > > +++ b/drivers/bluetooth/btmtk.c > > @@ -57,6 +57,7 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname, > > wmt_cmd_sync_func_t wmt_cmd_sync) > > { > > struct btmtk_hci_wmt_params wmt_params; > > + struct btmtk_patch_header *hdr; > > struct btmtk_global_desc *globaldesc = NULL; > > struct btmtk_section_map *sectionmap; > > const struct firmware *fw; > > @@ -75,9 +76,13 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname, > > > > fw_ptr = fw->data; > > fw_bin_ptr = fw_ptr; > > + hdr = (struct btmtk_patch_header *)fw_ptr; > > globaldesc = (struct btmtk_global_desc *)(fw_ptr + MTK_FW_ROM_PATCH_HEADER_SIZE); > > section_num = le32_to_cpu(globaldesc->section_num); > > > > + bt_dev_info(hdev, "HW/SW Version: 0x%04x%04x, Build Time: %s", > > Why not print 0x%04x/0x%04x, that means with a slash? > > > + le16_to_cpu(hdr->hwver), le16_to_cpu(hdr->swver), hdr->datetime); > > + > > for (i = 0; i < section_num; i++) { > > first_block = 1; > > fw_ptr = fw_bin_ptr; > > > Kind regards, > > Paul
diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c index 9482401d97fa..8490d59502a5 100644 --- a/drivers/bluetooth/btmtk.c +++ b/drivers/bluetooth/btmtk.c @@ -57,6 +57,7 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname, wmt_cmd_sync_func_t wmt_cmd_sync) { struct btmtk_hci_wmt_params wmt_params; + struct btmtk_patch_header *hdr; struct btmtk_global_desc *globaldesc = NULL; struct btmtk_section_map *sectionmap; const struct firmware *fw; @@ -75,9 +76,13 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname, fw_ptr = fw->data; fw_bin_ptr = fw_ptr; + hdr = (struct btmtk_patch_header *)fw_ptr; globaldesc = (struct btmtk_global_desc *)(fw_ptr + MTK_FW_ROM_PATCH_HEADER_SIZE); section_num = le32_to_cpu(globaldesc->section_num); + bt_dev_info(hdev, "HW/SW Version: 0x%04x%04x, Build Time: %s", + le16_to_cpu(hdr->hwver), le16_to_cpu(hdr->swver), hdr->datetime); + for (i = 0; i < section_num; i++) { first_block = 1; fw_ptr = fw_bin_ptr;