| Message ID | 20230704105021.898555-1-andreaskleist@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Input: exc3000 - add ACPI support for EXC80H60 | expand |
Hi Andreas, kernel test robot noticed the following build warnings: [auto build test WARNING on v6.4] [also build test WARNING on linus/master next-20230704] [cannot apply to dtor-input/next dtor-input/for-linus] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Helbech-Kleist/Input-exc3000-add-ACPI-support-for-EXC80H60/20230704-185127 base: v6.4 patch link: https://lore.kernel.org/r/20230704105021.898555-1-andreaskleist%40gmail.com patch subject: [PATCH] Input: exc3000 - add ACPI support for EXC80H60 config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230705/202307050124.E5Ze5uux-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230705/202307050124.E5Ze5uux-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307050124.E5Ze5uux-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/input/touchscreen/exc3000.c:460:38: warning: initialization of 'long unsigned int' from 'struct eeti_dev_info *' makes integer from pointer without a cast [-Wint-conversion] 460 | { "EGA00001", .driver_data = &exc3000_info[EETI_EXC80H60] }, | ^ drivers/input/touchscreen/exc3000.c:460:38: note: (near initialization for 'exc3000_acpi_match[0].driver_data') vim +460 drivers/input/touchscreen/exc3000.c 457 458 #ifdef CONFIG_ACPI 459 static const struct acpi_device_id exc3000_acpi_match[] = { > 460 { "EGA00001", .driver_data = &exc3000_info[EETI_EXC80H60] }, 461 { } 462 }; 463 MODULE_DEVICE_TABLE(acpi, exc3000_acpi_match); 464 #endif 465
Hi Andreas, kernel test robot noticed the following build errors: [auto build test ERROR on v6.4] [also build test ERROR on linus/master next-20230704] [cannot apply to dtor-input/next dtor-input/for-linus] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Helbech-Kleist/Input-exc3000-add-ACPI-support-for-EXC80H60/20230704-185127 base: v6.4 patch link: https://lore.kernel.org/r/20230704105021.898555-1-andreaskleist%40gmail.com patch subject: [PATCH] Input: exc3000 - add ACPI support for EXC80H60 config: x86_64-randconfig-x001-20230703 (https://download.01.org/0day-ci/archive/20230705/202307050258.WtWKQJdV-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230705/202307050258.WtWKQJdV-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307050258.WtWKQJdV-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/input/touchscreen/exc3000.c:460:31: error: incompatible pointer to integer conversion initializing 'kernel_ulong_t' (aka 'unsigned long') with an expression of type 'struct eeti_dev_info *' [-Wint-conversion] { "EGA00001", .driver_data = &exc3000_info[EETI_EXC80H60] }, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. vim +460 drivers/input/touchscreen/exc3000.c 457 458 #ifdef CONFIG_ACPI 459 static const struct acpi_device_id exc3000_acpi_match[] = { > 460 { "EGA00001", .driver_data = &exc3000_info[EETI_EXC80H60] }, 461 { } 462 }; 463 MODULE_DEVICE_TABLE(acpi, exc3000_acpi_match); 464 #endif 465
Hi Andreas, kernel test robot noticed the following build warnings: [auto build test WARNING on v6.4] [also build test WARNING on linus/master next-20230705] [cannot apply to dtor-input/next dtor-input/for-linus] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Helbech-Kleist/Input-exc3000-add-ACPI-support-for-EXC80H60/20230704-185127 base: v6.4 patch link: https://lore.kernel.org/r/20230704105021.898555-1-andreaskleist%40gmail.com patch subject: [PATCH] Input: exc3000 - add ACPI support for EXC80H60 config: i386-randconfig-i062-20230703 (https://download.01.org/0day-ci/archive/20230705/202307051716.GC4vKJUY-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230705/202307051716.GC4vKJUY-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307051716.GC4vKJUY-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/input/touchscreen/exc3000.c:460:51: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned long [usertype] driver_data @@ got struct eeti_dev_info * @@ drivers/input/touchscreen/exc3000.c:460:51: sparse: expected unsigned long [usertype] driver_data drivers/input/touchscreen/exc3000.c:460:51: sparse: got struct eeti_dev_info * vim +460 drivers/input/touchscreen/exc3000.c 457 458 #ifdef CONFIG_ACPI 459 static const struct acpi_device_id exc3000_acpi_match[] = { > 460 { "EGA00001", .driver_data = &exc3000_info[EETI_EXC80H60] }, 461 { } 462 }; 463 MODULE_DEVICE_TABLE(acpi, exc3000_acpi_match); 464 #endif 465
diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c index 69eae79e2087..f3a90155fb04 100644 --- a/drivers/input/touchscreen/exc3000.c +++ b/drivers/input/touchscreen/exc3000.c @@ -7,6 +7,7 @@ * minimal implementation based on egalax_ts.c and egalax_i2c.c */ +#include <linux/acpi.h> #include <linux/bitops.h> #include <linux/delay.h> #include <linux/device.h> @@ -454,10 +455,19 @@ static const struct of_device_id exc3000_of_match[] = { MODULE_DEVICE_TABLE(of, exc3000_of_match); #endif +#ifdef CONFIG_ACPI +static const struct acpi_device_id exc3000_acpi_match[] = { + { "EGA00001", .driver_data = &exc3000_info[EETI_EXC80H60] }, + { } +}; +MODULE_DEVICE_TABLE(acpi, exc3000_acpi_match); +#endif + static struct i2c_driver exc3000_driver = { .driver = { .name = "exc3000", .of_match_table = of_match_ptr(exc3000_of_match), + .acpi_match_table = ACPI_PTR(exc3000_acpi_match), }, .id_table = exc3000_id, .probe_new = exc3000_probe,
EXC80H60 is used in Ambu aBox2 with ACPI _HID "EGA00001". Snippet of from "apcidump -b; iasl ssdt2.dat" on target: Device (TPL2) { Name (HID2, Zero) Name (_HID, "EGA00001") // _HID: Hardware ID Name (_CID, "PNP0C50" /* HID Protocol Device (I2C bus) */) // _CID: Compatible ID Name (_S0W, 0x04) // _S0W: S0 Device Wake State Name (SBFB, ResourceTemplate () Signed-off-by: Andreas Helbech Kleist <andreaskleist@gmail.com> --- drivers/input/touchscreen/exc3000.c | 10 ++++++++++ 1 file changed, 10 insertions(+)