| Message ID | 20230628-topic-refgen-v3-0-9fbf0e605d23@linaro.org |
|---|---|
| Headers | show |
| Series | Qualcomm REFGEN regulator | expand |
On 3.07.2023 20:15, Konrad Dybcio wrote: > Modern Qualcomm SoCs have a REFGEN (reference voltage generator) > regulator, providing reference voltage to on-chip IP, like PHYs. > It's controlled through MMIO and we can toggle it or read its state back. > > Describe it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- I have a chronic issue where I realize I didn't run b4 trailers -u the milisecond I hit enter on b4 send. This was: Reviewed-by: Rob Herring <robh@kernel.org> at https://lore.kernel.org/linux-arm-msm/168814320140.1876966.17866889850041692910.robh@kernel.org/ Sorry for the inconvenience. Konrad > .../regulator/qcom,sdm845-refgen-regulator.yaml | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml > new file mode 100644 > index 000000000000..f02f97d4fdd2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/qcom,sdm845-refgen-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. REFGEN Regulator > + > +maintainers: > + - Konrad Dybcio <konradybcio@kernel.org> > + > +description: > + The REFGEN (reference voltage generator) regulator provides reference > + voltage for on-chip IPs (like PHYs) on some Qualcomm SoCs. > + > +allOf: > + - $ref: regulator.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - qcom,sc7180-refgen-regulator > + - qcom,sc8180x-refgen-regulator > + - qcom,sm8150-refgen-regulator > + - const: qcom,sdm845-refgen-regulator > + > + - items: > + - enum: > + - qcom,sc7280-refgen-regulator > + - qcom,sc8280xp-refgen-regulator > + - qcom,sm6350-refgen-regulator > + - qcom,sm6375-refgen-regulator > + - qcom,sm8350-refgen-regulator > + - const: qcom,sm8250-refgen-regulator > + > + - enum: > + - qcom,sdm845-refgen-regulator > + - qcom,sm8250-refgen-regulator > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + regulator@162f000 { > + compatible = "qcom,sm8250-refgen-regulator"; > + reg = <0x0162f000 0x84>; > + }; > +... >
On Mon, Jul 03, 2023 at 08:15:53PM +0200, Konrad Dybcio wrote: > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > responsible for providing a reference voltage to some on-SoC IPs (like DSI > or PHYs). It can be turned off when unused to save power. > > This series introduces the driver for it and lets the DSI driver > consume it. What's the expected plan for merging this - should I be applying the DRM patch?
On 4.07.2023 00:59, Mark Brown wrote: > On Mon, Jul 03, 2023 at 08:15:53PM +0200, Konrad Dybcio wrote: > >> Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator >> responsible for providing a reference voltage to some on-SoC IPs (like DSI >> or PHYs). It can be turned off when unused to save power. >> >> This series introduces the driver for it and lets the DSI driver >> consume it. > > What's the expected plan for merging this - should I be applying the DRM > patch? Uh sorry for not clarifying.. please just take the first two. Konrad
On Tue, 4 Jul 2023 at 01:59, Mark Brown <broonie@kernel.org> wrote: > > On Mon, Jul 03, 2023 at 08:15:53PM +0200, Konrad Dybcio wrote: > > > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > > responsible for providing a reference voltage to some on-SoC IPs (like DSI > > or PHYs). It can be turned off when unused to save power. > > > > This series introduces the driver for it and lets the DSI driver > > consume it. > > What's the expected plan for merging this - should I be applying the DRM > patch? I'd pick the least two patches into msm-next after -rc1.
On Mon, 03 Jul 2023 20:15:53 +0200, Konrad Dybcio wrote: > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > responsible for providing a reference voltage to some on-SoC IPs (like DSI > or PHYs). It can be turned off when unused to save power. > > This series introduces the driver for it and lets the DSI driver > consume it. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator commit: d16db38c2a66060ee25c6b86ee7b6d66d40fc8e0 [2/4] regulator: Introduce Qualcomm REFGEN regulator driver commit: 7cbfbe23796086fdb72b681e2c182b02acd36a04 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator responsible for providing a reference voltage to some on-SoC IPs (like DSI or PHYs). It can be turned off when unused to save power. This series introduces the driver for it and lets the DSI driver consume it. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Changes in v3: - depend on HAS_IOMEM (s390 build failure, meh) - constify regulator_ops - Link to v2: https://lore.kernel.org/r/20230628-topic-refgen-v2-0-6136487c78c5@linaro.org Changes in v2: - Remove "|" from bindings description - fix 'renegator' typo - define number of 'reg' - adjust reg= to size/address-cells = 1 - fix regmap usage - use C++ comments for the header - remove now-unused struct qcom_refgen - use common helpers for sm8250 refgen (simple bit ops) - add missing FIELD_PREPs (small brain forgot regmap_update_bits doesn't do shifting) - pick up tags - Link to v1: https://lore.kernel.org/r/20230628-topic-refgen-v1-0-126e59573eeb@linaro.org --- Konrad Dybcio (4): dt-bindings: regulator: Describe Qualcomm REFGEN regulator regulator: Introduce Qualcomm REFGEN regulator driver dt-bindings: display/msm: dsi-controller-main: Allow refgen-supply drm/msm/dsi: Hook up refgen regulator .../bindings/display/msm/dsi-controller-main.yaml | 4 + .../regulator/qcom,sdm845-refgen-regulator.yaml | 57 ++++++++ drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 + drivers/regulator/Kconfig | 11 ++ drivers/regulator/Makefile | 1 + drivers/regulator/qcom-refgen-regulator.c | 154 +++++++++++++++++++++ 6 files changed, 229 insertions(+) --- base-commit: 296d53d8f84ce50ffaee7d575487058c8d437335 change-id: 20230628-topic-refgen-14fb0b762115 Best regards,