| Message ID | 20230708213617.3759954-1-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: typc: qcom: properly report Audio Accessory mode | expand |
On Sun, Jul 09, 2023 at 12:36:17AM +0300, Dmitry Baryshkov wrote: Missing 'e' in $subject. Regards, Bjorn > Detect and report the if the Audio Accessory device has been attached to > the corresponding USB-C port. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > index 94285f64b67d..56df04af2d2b 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > @@ -214,6 +214,11 @@ int qcom_pmic_typec_port_get_cc(struct pmic_typec_port *pmic_typec_port, > if (ret) > goto done; > switch (val & DETECTED_SRC_TYPE_MASK) { > + case AUDIO_ACCESS_RA_RA: > + val = TYPEC_CC_RA; > + *cc1 = TYPEC_CC_RA; > + *cc2 = TYPEC_CC_RA; > + break; > case SRC_RD_OPEN: > val = TYPEC_CC_RD; > break; > -- > 2.39.2 >
On 7/9/23 12:36 AM, Dmitry Baryshkov wrote: > Detect and report the if the Audio Accessory device has been attached to ^^^ is it really needed here? > the corresponding USB-C port. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> [...] MBR, Sergey
On 08/07/2023 22:36, Dmitry Baryshkov wrote: > Detect and report the if the Audio Accessory device has been attached to > the corresponding USB-C port. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > index 94285f64b67d..56df04af2d2b 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > @@ -214,6 +214,11 @@ int qcom_pmic_typec_port_get_cc(struct pmic_typec_port *pmic_typec_port, > if (ret) > goto done; > switch (val & DETECTED_SRC_TYPE_MASK) { > + case AUDIO_ACCESS_RA_RA: > + val = TYPEC_CC_RA; > + *cc1 = TYPEC_CC_RA; > + *cc2 = TYPEC_CC_RA; > + break; > case SRC_RD_OPEN: > val = TYPEC_CC_RD; > break; With the spelling fixedup per Bjorn and Sergi Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c index 94285f64b67d..56df04af2d2b 100644 --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c @@ -214,6 +214,11 @@ int qcom_pmic_typec_port_get_cc(struct pmic_typec_port *pmic_typec_port, if (ret) goto done; switch (val & DETECTED_SRC_TYPE_MASK) { + case AUDIO_ACCESS_RA_RA: + val = TYPEC_CC_RA; + *cc1 = TYPEC_CC_RA; + *cc2 = TYPEC_CC_RA; + break; case SRC_RD_OPEN: val = TYPEC_CC_RD; break;
Detect and report the if the Audio Accessory device has been attached to the corresponding USB-C port. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 5 +++++ 1 file changed, 5 insertions(+)