| Message ID | 20230617171541.286957-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | c756d233715a899dd1cce4b1db4cbd50b0f55a9e |
| Headers | show |
| Series | [01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names | expand |
On 17.06.2023 19:15, Krzysztof Kozlowski wrote: > The children of qcom,smp2p do not need address/size-cells: > > msm8939-sony-xperia-kanuti-tulip.dtb: smp2p-hexagon: slave-kernel: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/msm8939.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi > index 895cafc11480..05d8abbbc840 100644 > --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi > @@ -386,8 +386,6 @@ hexagon_smp2p_in: slave-kernel { > > interrupt-controller; > #interrupt-cells = <2>; > - #address-cells = <0>; > - #size-cells = <0>; > }; > }; >
On 17.06.2023 19:15, Krzysztof Kozlowski wrote: > Use generic node names for I2C devices. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi > index 8c2d6e9e851b..bcd2397eb373 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi > @@ -189,7 +189,7 @@ &blsp2_i2c2 { > status = "okay"; > clock-frequency = <400000>; > > - nfc: pn548@28 { > + nfc: nfc@28 { > compatible = "nxp,nxp-nci-i2c"; > > reg = <0x28>; > @@ -208,7 +208,7 @@ nfc: pn548@28 { > &blsp2_i2c3 { > status = "okay"; > > - typec: tusb320l@47 { > + typec: typec@47 { > compatible = "ti,tusb320l"; > reg = <0x47>; > interrupt-parent = <&tlmm>;
On 17.06.2023 19:15, Krzysztof Kozlowski wrote: > Bluetooth requires VDDIO supply. Due to lack of schematics provide > something dummy to satisfy `dtbs_check`: > > sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- For this: Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> +CC Doug to perhaps fix this properly (though I think we should have got it through the cros list anyway) Konrad > arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > index afae7f46b050..b1aa5b0ee95c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > @@ -24,6 +24,13 @@ aliases { > chosen { > stdout-path = "serial0:115200n8"; > }; > + > + bt_vddio: regulator-bt-vddio { > + compatible = "regulator-fixed"; > + regulator-name = "bt-vddio"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > }; > > &apps_rsc { > @@ -38,6 +45,10 @@ vreg_s1k_1p0: smps1 { > }; > }; > > +&bluetooth { > + vddio-supply = <&bt_vddio>; > +}; > + > ap_tp_i2c: &i2c0 { > status = "okay"; > clock-frequency = <400000>;
Hi, On Mon, Jun 19, 2023 at 6:14 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 17.06.2023 19:15, Krzysztof Kozlowski wrote: > > Bluetooth requires VDDIO supply. Due to lack of schematics provide > > something dummy to satisfy `dtbs_check`: > > > > sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > For this: > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > +CC Doug to perhaps fix this properly (though I think we should have got > it through the cros list anyway) > > Konrad > > arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > > index afae7f46b050..b1aa5b0ee95c 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > > @@ -24,6 +24,13 @@ aliases { > > chosen { > > stdout-path = "serial0:115200n8"; > > }; > > + > > + bt_vddio: regulator-bt-vddio { > > + compatible = "regulator-fixed"; > > + regulator-name = "bt-vddio"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + }; > > }; > > > > &apps_rsc { > > @@ -38,6 +45,10 @@ vreg_s1k_1p0: smps1 { > > }; > > }; > > > > +&bluetooth { > > + vddio-supply = <&bt_vddio>; > > +}; > > + I would have a hard time believing that the more correct fix wouldn't be: vddio-supply = <&vreg_l18b_1p8>; Specifically L18B is what we have on the newer CRD (the one that is considered a "herobrine" and includes Qcard) and also IDP2. In terms of timeline / similarities, CRD-rev3 falls in between IDP2 and newer CRD. These both agree on L18B. The only board that uses something different (L19B) is the very old IDP1. That being said, Qualcomm has never provided (at least to me) schematics for any given reference board. Whenever asked, I was always pointed at schematics that were said to be "close enough". Thus, I can't really give a definitive answer here. Even so, pointing at L18B seems to me to be 99% likely to be correct. If anyone reading actually has schematics, I think you can just look at what goes to the pad labelled "VDDPX_3". The datasheet I have shows that as "Pad group 3 (most peripherals)". If nothing else, that powers the pins connected to the UART that Bluetooth uses (along with a whole pile of other things in the system). -Doug
On 23/06/2023 20:34, Doug Anderson wrote: > Hi, > > On Mon, Jun 19, 2023 at 6:14 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> On 17.06.2023 19:15, Krzysztof Kozlowski wrote: >>> Bluetooth requires VDDIO supply. Due to lack of schematics provide >>> something dummy to satisfy `dtbs_check`: >>> >>> sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >> For this: >> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> >> +CC Doug to perhaps fix this properly (though I think we should have got >> it through the cros list anyway) >> >> Konrad >>> arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 11 +++++++++++ >>> 1 file changed, 11 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts >>> index afae7f46b050..b1aa5b0ee95c 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts >>> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts >>> @@ -24,6 +24,13 @@ aliases { >>> chosen { >>> stdout-path = "serial0:115200n8"; >>> }; >>> + >>> + bt_vddio: regulator-bt-vddio { >>> + compatible = "regulator-fixed"; >>> + regulator-name = "bt-vddio"; >>> + regulator-min-microvolt = <1800000>; >>> + regulator-max-microvolt = <1800000>; >>> + }; >>> }; >>> >>> &apps_rsc { >>> @@ -38,6 +45,10 @@ vreg_s1k_1p0: smps1 { >>> }; >>> }; >>> >>> +&bluetooth { >>> + vddio-supply = <&bt_vddio>; >>> +}; >>> + > > I would have a hard time believing that the more correct fix wouldn't be: > > vddio-supply = <&vreg_l18b_1p8>; > > Specifically L18B is what we have on the newer CRD (the one that is > considered a "herobrine" and includes Qcard) and also IDP2. In terms > of timeline / similarities, CRD-rev3 falls in between IDP2 and newer > CRD. These both agree on L18B. The only board that uses something > different (L19B) is the very old IDP1. > > That being said, Qualcomm has never provided (at least to me) > schematics for any given reference board. Whenever asked, I was always > pointed at schematics that were said to be "close enough". Thus, I > can't really give a definitive answer here. Even so, pointing at L18B > seems to me to be 99% likely to be correct. 99% is good enough for me. Thanks, I will send a v2 after the merge window. Best regards, Krzysztof
On Sat, 17 Jun 2023 19:15:27 +0200, Krzysztof Kozlowski wrote: > st,lis2hh12 accelerometer binding does not allow interrupt-names: > > msm8916-samsung-gt58.dtb: accelerometer@1d: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > Applied, thanks! [01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names commit: c756d233715a899dd1cce4b1db4cbd50b0f55a9e [02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply commit: 6a541eaa6e8e5283efb993ae7a947bede8d01fa5 [03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI commit: 031df8e650a8584d24c91fa64465e0660accd339 [04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C commit: d4bbcf50baa9d7f70e97a3fd3b0d5e4f599a6217 [05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties commit: 35cda57217adceee2f6bc738a1d98a2cccab709e [06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C commit: 368f8d196976e691af9cb8e61c9c852d574759fb [07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names commit: f7eb45427af670e48a9d28e6bbe7c6b8f68c3bfe [08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names commit: 0ec3a3e1b84bc27d482a6cab4e7ab7e2dd26ecf6 [10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names commit: 978869867216e669b6bed11aa669317a11e0dc7a [11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings commit: 9ca4673201cc08df152a4ec054d81ae6a6895938 [12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports commit: bee2dea5be813eafc7979c09854b447abd75dfd0 [13/15] arm64: dts: qcom: sc8180x-primus: correct panel ports commit: 0f06e8cbd18e7f0e016f21c870f7d7af20ffd47e [14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings commit: adc2ee325806e805f9d729f28dd1ac77dd82932a [15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup commit: c8df0c62cb6a21b98845c44c3539aa727874cd08 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi index 7943bb619116..54d648972d35 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi @@ -101,7 +101,6 @@ accelerometer@1d { interrupt-parent = <&tlmm>; interrupts = <115 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "INT1"; st,drdy-int-pin = <1>; mount-matrix = "0", "1", "0",
st,lis2hh12 accelerometer binding does not allow interrupt-names: msm8916-samsung-gt58.dtb: accelerometer@1d: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 1 - 1 file changed, 1 deletion(-)