| Message ID | 20230714171642.91185-1-javierm@redhat.com |
|---|---|
| Headers | show |
| Series | Allow disabling all native fbdev drivers and only keeping DRM emulation | expand |
On Fri, Jul 14, 2023, at 19:16, Javier Martinez Canillas wrote: > This patch series splits the fbdev core support in two different Kconfig > symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to > be disabled, while still having the the core fbdev support needed for the > CONFIG_DRM_FBDEV_EMULATION to be enabled. The motivation is automatically > disabling all fbdev drivers instead of having to be disabled individually. > > The reason for doing this is that now with simpledrm, there's no need for > the legacy fbdev (e.g: efifb or vesafb) drivers anymore and many distros > now disable them. But it would simplify the config a lot fo have a single > Kconfig symbol to disable all fbdev drivers. > > I've built tested with possible combinations of CONFIG_FB, CONFIG_FB_CORE, > CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE symbols set to 'y' or 'n'. > > Patch #1 moves the auxdisplay drivers to "Graphics support" Kconfig menu, > patch #2 moves the core fbdev Kconfig symbols to a separate Kconfig file, > patch #3 does the FB symbol split and introduces the FB_CORE symbol and > finally patch #4 makes the DRM symbol to select FB_CORE if the DRM fbdev > emualtion support was enabled. > > Since this series touches three subsystems (auxdisplay, fbdev and DRM), > I would like to merge it through DRM with the acks of these maintainers. > > This is a v5 of the patch-set that addresses issues pointed out by Arnd > Bergmann, Thomas Zimmermann and Geert Uytterhoeven in the previous v4: > > https://lists.freedesktop.org/archives/dri-devel/2023-July/411842.html Looks all good to me, except for two minor things I found in build testing and replied to separately. With those fixed: Reviewed-by: Arnd Bergmann <arnd@arndb.de> Tested-by: Arnd Bergmann <arnd@arndb.de>
"Arnd Bergmann" <arnd@arndb.de> writes: > On Fri, Jul 14, 2023, at 19:16, Javier Martinez Canillas wrote: >> This patch series splits the fbdev core support in two different Kconfig >> symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to >> be disabled, while still having the the core fbdev support needed for the >> CONFIG_DRM_FBDEV_EMULATION to be enabled. The motivation is automatically >> disabling all fbdev drivers instead of having to be disabled individually. >> >> The reason for doing this is that now with simpledrm, there's no need for >> the legacy fbdev (e.g: efifb or vesafb) drivers anymore and many distros >> now disable them. But it would simplify the config a lot fo have a single >> Kconfig symbol to disable all fbdev drivers. >> >> I've built tested with possible combinations of CONFIG_FB, CONFIG_FB_CORE, >> CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE symbols set to 'y' or 'n'. >> >> Patch #1 moves the auxdisplay drivers to "Graphics support" Kconfig menu, >> patch #2 moves the core fbdev Kconfig symbols to a separate Kconfig file, >> patch #3 does the FB symbol split and introduces the FB_CORE symbol and >> finally patch #4 makes the DRM symbol to select FB_CORE if the DRM fbdev >> emualtion support was enabled. >> >> Since this series touches three subsystems (auxdisplay, fbdev and DRM), >> I would like to merge it through DRM with the acks of these maintainers. >> >> This is a v5 of the patch-set that addresses issues pointed out by Arnd >> Bergmann, Thomas Zimmermann and Geert Uytterhoeven in the previous v4: >> >> https://lists.freedesktop.org/archives/dri-devel/2023-July/411842.html > > Looks all good to me, except for two minor things I found in build testing > and replied to separately. With those fixed: > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > Tested-by: Arnd Bergmann <arnd@arndb.de> > Awesome, thanks a lot for your help!