diff mbox series

[2/2] dt-bindings: usb: qcom,dwc3: correct SDM660 clocks

Message ID 20230723141550.90223-2-krzysztof.kozlowski@linaro.org
State Accepted
Commit 0497d34625167c0841d4828a28a26a10a2e9edde
Headers show
Series None | expand

Commit Message

Krzysztof Kozlowski July 23, 2023, 2:15 p.m. UTC 
SDM660 SoC has two instances of DWC3 USB controller: one supporting USB
3.0 and one supporting only up to USB 2.0.  The latter one does not use
iface clock, so allow such variant to fix dtbs_check warnings:

  sda660-inforce-ifc6560.dtb: usb@c2f8800: clocks: [[37, 48], [37, 88], [37, 89], [37, 90]] is too short
  sda660-inforce-ifc6560.dtb: usb@c2f8800: clock-names:2: 'iface' was expected

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/usb/qcom,dwc3.yaml    | 24 ++++++++++++-------
 1 file changed, 16 insertions(+), 8 deletions(-)

Comments

Rob Herring July 24, 2023, 4:29 p.m. UTC | #1 
On Sun, 23 Jul 2023 16:15:50 +0200, Krzysztof Kozlowski wrote:
> SDM660 SoC has two instances of DWC3 USB controller: one supporting USB
> 3.0 and one supporting only up to USB 2.0.  The latter one does not use
> iface clock, so allow such variant to fix dtbs_check warnings:
> 
>   sda660-inforce-ifc6560.dtb: usb@c2f8800: clocks: [[37, 48], [37, 88], [37, 89], [37, 90]] is too short
>   sda660-inforce-ifc6560.dtb: usb@c2f8800: clock-names:2: 'iface' was expected
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/usb/qcom,dwc3.yaml    | 24 ++++++++++++-------
>  1 file changed, 16 insertions(+), 8 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 7cedd751161d..b84b104f2975 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -284,15 +284,23 @@  allOf:
     then:
       properties:
         clocks:
-          minItems: 6
+          minItems: 5
+          maxItems: 6
         clock-names:
-          items:
-            - const: cfg_noc
-            - const: core
-            - const: iface
-            - const: sleep
-            - const: mock_utmi
-            - const: bus
+          oneOf:
+            - items:
+                - const: cfg_noc
+                - const: core
+                - const: iface
+                - const: sleep
+                - const: mock_utmi
+                - const: bus
+            - items:
+                - const: cfg_noc
+                - const: core
+                - const: sleep
+                - const: mock_utmi
+                - const: bus
 
   - if:
       properties: