| Message ID | 20230627-topic-more_bindings-v1-9-6b4b6cd081e5@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Even more msm bindings fixes | expand |
On Tue, 27 Jun 2023 18:24:25 +0200, Konrad Dybcio wrote: > The description of reg[1] says that register is optional. Adjust > minItems to make it truly optional. > > Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
On 27/06/2023 18:24, Konrad Dybcio wrote: > The description of reg[1] says that register is optional. Adjust > minItems to make it truly optional. > > Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- This patch does not make sense. It wasn't also tested. The code (minItems) is already there. Best regards, Krzysztof
On 24/07/2023 11:05, Krzysztof Kozlowski wrote: > On 27/06/2023 18:24, Konrad Dybcio wrote: >> The description of reg[1] says that register is optional. Adjust >> minItems to make it truly optional. >> >> Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml") >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- > > This patch does not make sense. It wasn't also tested. The code > (minItems) is already there. What's more - there is no such commit as 12f40018b6a9! Bjorn, You might find this useful (fake Fixes tag should be detected): https://github.com/krzk/tools/blob/master/linux/git-hooks-post-commit Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml index 5e16121d9f0d..75b6287db2c9 100644 --- a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml +++ b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml @@ -22,6 +22,7 @@ properties: - qcom,kpss-acc-v2 reg: + minItems: 1 items: - description: Base address and size of the register region - description: Optional base address and size of the alias register region
The description of reg[1] says that register is optional. Adjust minItems to make it truly optional. Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml") Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml | 1 + 1 file changed, 1 insertion(+)