| Message ID | 20230627-topic-more_bindings-v1-0-6b4b6cd081e5@linaro.org |
|---|---|
| Headers | show |
| Series | Even more msm bindings fixes | expand |
On Tue, 27 Jun 2023 18:24:23 +0200, Konrad Dybcio wrote: > Some IOMMUs on some platforms (there doesn't seem to be a good denominator > for this) require the presence of a third clock, specifically for > accessing the IOMMU's Translation Buffer Unit (TBU). Allow it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/iommu/qcom,iommu.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On 29.06.2023 17:23, Rob Herring wrote: > On Tue, Jun 27, 2023 at 06:24:24PM +0200, Konrad Dybcio wrote: >> Untangle the bit messy oneOf trees and add the missing pinctrl-2 mention >> to handle the different pinctrl combinations. >> >> Fixes: 4c8375d35f72 ("dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format") >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 27 ++++++---------------- >> 1 file changed, 7 insertions(+), 20 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >> index 782402800d4a..24431a7adf3e 100644 >> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >> @@ -199,17 +199,6 @@ properties: >> In case of HSIC-mode, "idle" and "active" pin modes are mandatory. >> In this case, the "idle" state needs to pull down the data and >> strobe pin and the "active" state needs to pull up the strobe pin. >> - oneOf: >> - - items: >> - - const: idle >> - - const: active > > These are no longer valid values? The description still mentions them. I believe allOf: now covers them all? > >> - - items: >> - - const: default >> - - enum: >> - - host >> - - device >> - - items: >> - - const: default >> >> pinctrl-0: >> maxItems: 1 >> @@ -357,17 +346,15 @@ allOf: >> - const: active >> else: >> properties: >> + pinctrl-2: > > This should be implicitly allowed. Is it not? No, it errored out for me. > > I'm reallly at a loss as to what problem this patch solves. Specifying all 3 pin states is impossible with the current state of this binding, even though it's a supported configuration (check qcom/apq8039-t2.dtb). I should have been more clear in the commit message. Konrad > >> + maxItems: 1 >> + >> pinctrl-names: >> minItems: 1 >> - maxItems: 2 >> - oneOf: >> - - items: >> - - const: default >> - - enum: >> - - host >> - - device >> - - items: >> - - const: default >> + items: >> + - const: default >> + - const: host >> + - const: device >> - if: >> properties: >> compatible: >> >> -- >> 2.41.0 >>
On Tue, 27 Jun 2023 18:24:16 +0200, Konrad Dybcio wrote: > This series contains couple more random dt schema warning fixes, centered > around linux-msm. > > All of the patches (except) the last two are pretty much independent. > Patch 1 is not only a bindings fix, but also a functional one. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [05/11] dt-bindings: sound: Convert pm8916-wcd-analog-codec to YAML commit: e125891c2ed6f6d3f59375caf04d76802c86efae All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Tue, 27 Jun 2023, Konrad Dybcio wrote: > Now that it's been converted to YAML, reference the PM8916 wcd codec > schema. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks
On Tue, 27 Jun 2023 18:24:16 +0200, Konrad Dybcio wrote: > This series contains couple more random dt schema warning fixes, centered > around linux-msm. > > All of the patches (except) the last two are pretty much independent. > Patch 1 is not only a bindings fix, but also a functional one. > > > [...] Applied, thanks! [09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional commit: 981be238e1d28e156aa9da2a8722f86f02fd0453 Best regards,
Hi, On Tue, Jun 27, 2023 at 9:24 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > Commit 2b616f86d51b ("arm64: dts: qcom: sc7180: rename labels for DSI > nodes") broke reg-names, possibly with search-and-replace. Fix it. > > Fixes: 2b616f86d51b ("arm64: dts: qcom: sc7180: rename labels for DSI nodes") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 34eff97f8630..b9640574e73b 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3120,8 +3120,8 @@ mdss_dsi0_phy: phy@ae94400 { > reg = <0 0x0ae94400 0 0x200>, > <0 0x0ae94600 0 0x280>, > <0 0x0ae94a00 0 0x1e0>; > - reg-names = "dsi0_phy", > - "dsi0_phy_lane", > + reg-names = "dsi_phy", > + "dsi_phy_lane", I noticed that this patch got applied [1], but I think it got put into a branch targeting 6.6 instead of 6.5. Specifically I see it in "arm64-for-6.6" but not "arm64-fixes-for-6.5". Any chance it could be landed in a "Fixes" tree and get sent out sooner rather than later? v6.5 will be pretty broken without it and it would be nice to see it in Linus's tree sooner rather than later. [1] https://lore.kernel.org/r/168896565982.1376307.13166434967387866925.b4-ty@kernel.org Thanks! -Doug
This series contains couple more random dt schema warning fixes, centered around linux-msm. All of the patches (except) the last two are pretty much independent. Patch 1 is not only a bindings fix, but also a functional one. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Konrad Dybcio (11): arm64: dts: qcom: sc7180: Fix DSI0_PHY reg-names arm64: dts: qcom: msm8939: Drop "qcom,idle-state-spc" compatible arm64: dts: qcom: msm8939: Add missing 'cache-unified' to L2 arm64: dts: qcom: apq8039-t2: Drop inexistent property dt-bindings: sound: Convert pm8916-wcd-analog-codec to YAML dt-bindings: mfd: qcom,spmi-pmic: Reference pm8916 wcd analog codec schema dt-bindings: iommu: qcom_iommu: Allow 'tbu' clock dt-bindings: usb: ci-hdrc-usb2: Fix handling pinctrl properties dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional dt-bindings: usb: dwc3: Allow just 1 interrupt for MSM8996 arm64: dts: qcom: msm8996: Add missing interrupt to the USB2 controller .../devicetree/bindings/arm/msm/qcom,kpss-acc.yaml | 1 + .../devicetree/bindings/iommu/qcom,iommu.yaml | 4 + .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 +- .../bindings/sound/qcom,msm8916-wcd-analog.txt | 101 ------------- .../sound/qcom,pm8916-wcd-analog-codec.yaml | 160 +++++++++++++++++++++ .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 27 +--- .../devicetree/bindings/usb/qcom,dwc3.yaml | 2 +- arch/arm64/boot/dts/qcom/apq8039-t2.dts | 1 - arch/arm64/boot/dts/qcom/msm8939.dtsi | 4 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 3 + arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 +- 11 files changed, 182 insertions(+), 127 deletions(-) --- base-commit: 3eedd211ad93c322fb360b83a3d76a2c6cd622dc change-id: 20230627-topic-more_bindings-325a6f4b93a7 Best regards,