| Message ID | 20230728173520.486025-1-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/ppc: Disable goto_tb with architectural singlestep | expand |
Cc qemu-stable. On 7/28/23 10:35, Richard Henderson wrote: > The change to use translator_use_goto_tb went too far, as the > CF_SINGLE_STEP flag managed by the translator only handles > gdb single stepping and not the architectural single stepping > modeled in DisasContext.singlestep_enabled. > > Fixes: 6e9cc373ec5 ("target/ppc: Use translator_use_goto_tb") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1795 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/ppc/translate.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index e6a0709066..74796ec7ba 100644 > --- a/target/ppc/translate.c > +++ b/target/ppc/translate.c > @@ -4175,6 +4175,9 @@ static void pmu_count_insns(DisasContext *ctx) > > static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest) > { > + if (unlikely(ctx->singlestep_enabled)) { > + return false; > + } > return translator_use_goto_tb(&ctx->base, dest); > } >
On 7/28/23 19:35, Richard Henderson wrote: > The change to use translator_use_goto_tb went too far, as the > CF_SINGLE_STEP flag managed by the translator only handles > gdb single stepping and not the architectural single stepping > modeled in DisasContext.singlestep_enabled. > > Fixes: 6e9cc373ec5 ("target/ppc: Use translator_use_goto_tb") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1795 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > target/ppc/translate.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index e6a0709066..74796ec7ba 100644 > --- a/target/ppc/translate.c > +++ b/target/ppc/translate.c > @@ -4175,6 +4175,9 @@ static void pmu_count_insns(DisasContext *ctx) > > static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest) > { > + if (unlikely(ctx->singlestep_enabled)) { > + return false; > + } > return translator_use_goto_tb(&ctx->base, dest); > } >
On 28/7/23 19:35, Richard Henderson wrote: > The change to use translator_use_goto_tb went too far, as the > CF_SINGLE_STEP flag managed by the translator only handles > gdb single stepping and not the architectural single stepping > modeled in DisasContext.singlestep_enabled. > > Fixes: 6e9cc373ec5 ("target/ppc: Use translator_use_goto_tb") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1795 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/ppc/translate.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/target/ppc/translate.c b/target/ppc/translate.c index e6a0709066..74796ec7ba 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -4175,6 +4175,9 @@ static void pmu_count_insns(DisasContext *ctx) static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest) { + if (unlikely(ctx->singlestep_enabled)) { + return false; + } return translator_use_goto_tb(&ctx->base, dest); }
The change to use translator_use_goto_tb went too far, as the CF_SINGLE_STEP flag managed by the translator only handles gdb single stepping and not the architectural single stepping modeled in DisasContext.singlestep_enabled. Fixes: 6e9cc373ec5 ("target/ppc: Use translator_use_goto_tb") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1795 Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/ppc/translate.c | 3 +++ 1 file changed, 3 insertions(+)