| Message ID | 20230728074944.26746-1-zhuyinbo@loongson.cn |
|---|---|
| Headers | show |
| Series | soc: loongson2_pm: add power management support | expand |
Reviewd-by: Huacai Chen <chenhuacai@loongson.cn> > -----原始邮件----- > 发件人: "Yinbo Zhu" <zhuyinbo@loongson.cn> > 发送时间:2023-07-28 15:49:42 (星期五) > 收件人: "Arnd Bergmann" <arnd@arndb.de>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org > 抄送: "Jianmin Lv" <lvjianmin@loongson.cn>, wanghongliang@loongson.cn, "Liu Peibao" <liupeibao@loongson.cn>, loongson-kernel@lists.loongnix.cn, "Yinbo Zhu" <zhuyinbo@loongson.cn>, "Liu Yun" <liuyun@loongson.cn> > 主题: [PATCH v5 0/2] soc: loongson2_pm: add power management support > > Loongson-2 platform support Power Management Controller (ACPI) and this > series patch was to add PM driver that base on dts and PM binding support. > > Change in v5: > 1. The patch "[PATCH v3 1/3] loongarch: export some arch-specific > pm interfaces" had been merged into linux-next tree thus this > v4 series patch need drop it and need depend on it and it's > patch link was: > https://lore.kernel.org/all/20230615091757.24686-2-zhuyinbo@loongson.cn/ > 2. Swap the positions of compatible for 2k1000 and 2k0500. > Change in v4: > 1. The patch "[PATCH v3 1/3] loongarch: export some arch-specific > pm interfaces" had been merged into linux-next tree thus this > v4 series patch need drop it and need depend on it and it's > patch link was: > https://lore.kernel.org/all/20230615091757.24686-2-zhuyinbo@loongson.cn/ > 2. Remove the pmc label in dt-binding patch. > 3. Add the Co-developed-by for driver patch. > 4. Simplify the loongson2_suspend_valid_state that "return > (state == PM_SUSPEND_MEM)". > 5. Use Using loongson2_pm_irq_enable() to replace. > loongson2_power_button_irq_enable(). > 6. Remove the "oneOf" in dt-bindings patch. > 7. Replace "suspend-address" that use "loongson,suspend-address". > 8. Use u64 type that for "loongson,suspend-address". > 9. Rename "pm" to "power-mangement" in dt-bindings patch. > 10. Add the reivewed-by for dt-bindings patch. > Change in v3: > 1. Reword the [1/3] patch commit log and title. > 2. Use the old naming for suspend interface for the [1/3] and > [3/3] patch. > 3. Combine some small function in the driver patch. > 4. Rename 'pwrbt' to 'button' in the driver patch. > 5. Use the specific compatible in yaml file. > Change in v2: > 1. Fixup the "suspend-address" description. > 2. Remove the "return -EINVAL" in PM driver probe when firmware > no configure "suspend-address" property in dts in oder to > other PM state to work. > > Yinbo Zhu (2): > soc: dt-bindings: add loongson-2 pm > soc: loongson2_pm: add power management support > > .../soc/loongson/loongson,ls2k-pmc.yaml | 52 +++++ > MAINTAINERS | 7 + > drivers/soc/loongson/Kconfig | 10 + > drivers/soc/loongson/Makefile | 1 + > drivers/soc/loongson/loongson2_pm.c | 215 ++++++++++++++++++ > 5 files changed, 285 insertions(+) > > -- > 2.20.1 > > _______________________________________________ > Loongson-kernel mailing list -- loongson-kernel@lists.loongnix.cn > To unsubscribe send an email to loongson-kernel-leave@lists.loongnix.cn 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.
On Fri, Jul 28, 2023 at 10:36:42AM +0200, Krzysztof Kozlowski wrote: > On 28/07/2023 10:27, 陈华才 wrote: > > Reviewd-by: Huacai Chen <chenhuacai@loongson.cn> > > ... > > > > > > > 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 > > This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it. > > > Ooops! > > Are we intended person/entities to receive your Reviewed-by tag? It's okay, you only got a "Reviewd-by" tag ;) > We will > be using it (total/partial disclosure, reproduction, dissemination). > People not on To/Cc will also do it and for sure they are not intended > recipients. > > Please talk with your IT that such disclaimers in open-source are not > desired (if not harmful even).
Hi, Conor, Arnd, On Fri, Jul 28, 2023 at 4:44 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > Hey, > > +CC Huacai & WANG. > > On Fri, Jul 28, 2023 at 03:49:42PM +0800, Yinbo Zhu wrote: > > Loongson-2 platform support Power Management Controller (ACPI) and this > > series patch was to add PM driver that base on dts and PM binding support. > > > > Change in v5: > > 1. The patch "[PATCH v3 1/3] loongarch: export some arch-specific > > pm interfaces" had been merged into linux-next tree thus this > > v4 series patch need drop it and need depend on it and it's > > patch link was: > > https://lore.kernel.org/all/20230615091757.24686-2-zhuyinbo@loongson.cn/ > > Just to note, it might be in linux-next, but more importantly it is also > in v6.5-rc1, so there is no issue with dependencies. > > > 2. Swap the positions of compatible for 2k1000 and 2k0500. > > I noticed you sent a mail pinging the v4 of this series yesterday as it > had not been picked up. Who do you actually expect to apply these > patches? There does not appear to be a maintainer listed for the > drivers/soc/loongson directory, just one for your GUTS driver. > > As a result, patches like > <https://lore.kernel.org/all/a69170cb55cfc73e378b40ccf1d9c16f@208suo.com/> > have gone ignored. Granted, that patch is probably crap that does not > apply, due to 208suo.com people sending corrupted patches, but you the > point. > > More interestingly there is also > <https://lore.kernel.org/all/40b324af-3483-4b3d-b65a-a97944aa4a70@app.fastmail.com/> > which seems to have also gone missing (I don't see it in linux-next), > despite some discussion about how the patch should be merged. > > Looks to me like drivers/soc/loongson/ needs someone to take > responsibility for picking up patches for the directory & sending them > to the soc maintainers (with a new MAINTAINERS entry reflecting that) so > that patches don't fall through the cracks. As discussed when the guts driver gets merged, I think it is better to go via Arnd's soc tree for these patches under drivers/soc/loongson/. To Krzysztof, I'm very sorry for the disclaimer, I will remove it, and please take it easy. Huacai > > Thanks, > Conor.
On Fri, Jul 28, 2023 at 05:48:29PM +0800, Huacai Chen wrote: > On Fri, Jul 28, 2023 at 4:44 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > On Fri, Jul 28, 2023 at 03:49:42PM +0800, Yinbo Zhu wrote: > > > Loongson-2 platform support Power Management Controller (ACPI) and this > > > series patch was to add PM driver that base on dts and PM binding support. > > > > > > Change in v5: > > > 1. The patch "[PATCH v3 1/3] loongarch: export some arch-specific > > > pm interfaces" had been merged into linux-next tree thus this > > > v4 series patch need drop it and need depend on it and it's > > > patch link was: > > > https://lore.kernel.org/all/20230615091757.24686-2-zhuyinbo@loongson.cn/ > > > > Just to note, it might be in linux-next, but more importantly it is also > > in v6.5-rc1, so there is no issue with dependencies. > > > > > 2. Swap the positions of compatible for 2k1000 and 2k0500. > > > > I noticed you sent a mail pinging the v4 of this series yesterday as it > > had not been picked up. Who do you actually expect to apply these > > patches? There does not appear to be a maintainer listed for the > > drivers/soc/loongson directory, just one for your GUTS driver. > > > > As a result, patches like > > <https://lore.kernel.org/all/a69170cb55cfc73e378b40ccf1d9c16f@208suo.com/> > > have gone ignored. Granted, that patch is probably crap that does not > > apply, due to 208suo.com people sending corrupted patches, but you the > > point. > > > > More interestingly there is also > > <https://lore.kernel.org/all/40b324af-3483-4b3d-b65a-a97944aa4a70@app.fastmail.com/> > > which seems to have also gone missing (I don't see it in linux-next), > > despite some discussion about how the patch should be merged. > > > > Looks to me like drivers/soc/loongson/ needs someone to take > > responsibility for picking up patches for the directory & sending them > > to the soc maintainers (with a new MAINTAINERS entry reflecting that) so > > that patches don't fall through the cracks. > As discussed when the guts driver gets merged, I think it is better to > go via Arnd's soc tree for these patches under drivers/soc/loongson/. Discussed perhaps, and that does seem to me like the correct thing to do, but nobody actually did anything about it. Somebody needs to set up a git tree, add a MAINTAINERS entry for the directory, actually apply the patches and then send a PR to the soc maintainers (as mentioned by Arnd in the second patch I linked there). Perhaps that someone is you, or maybe it is Yinbo, up to you guys to decide :) Cheers, Conor.
On Fri, Jul 28, 2023, at 09:49, Yinbo Zhu wrote: > The Loongson-2's power management controller was ACPI, supports ACPI > S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To > Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods > (USB, GMAC, PWRBTN, etc.). This driver was to add power management > controller support that base on dts for Loongson-2 series SoCs. > > Co-developed-by: Liu Yun <liuyun@loongson.cn> > Signed-off-by: Liu Yun <liuyun@loongson.cn> > Co-developed-by: Liu Peibao <liupeibao@loongson.cn> > Signed-off-by: Liu Peibao <liupeibao@loongson.cn> > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> Adding Ulf Hansson to Cc Ulf has recently split out the "genpd" framework and split out drivers/genpd from drivers/soc since I'm generally not that involved in the pwoer management side. Can you have a look at whether this driver should also be part of drivers/genpd rather than drivers/soc, and/or converted to use the genpd infrastructure? Thanks, Arnd
Hi-- On 7/28/23 00:49, Yinbo Zhu wrote: > +config LOONGSON2_PM > + bool "Loongson-2 SoC Power Management Controller Driver" > + depends on LOONGARCH && OF > + help > + The Loongson-2's power management controller was ACPI, supports ACPI > + S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To > + Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods > + (USB, GMAC, PWRBTN, etc.). This driver was to add power management > + controller support that base on dts for Loongson-2 series SoCs. Kconfig help text should be indented with one tab +2 spaces, as documented in Documentation/process/coding-style.rst. thanks.
On Mon, Jul 31, 2023 at 09:28:11PM +0200, Arnd Bergmann wrote: > On Mon, Jul 31, 2023, at 16:13, Huacai Chen wrote: > > On Fri, Jul 28, 2023 at 6:18 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > >> > >> Perhaps that someone is you, or maybe it is Yinbo, up to you guys to > >> decide :) > > I'm a "merge hater" and "rebase lover", so I think it is better that > > Arnd picks up these patches to the soc tree directly. But if > > necessary, I can also create a "soc-loongson-next" branch in my tree > > and then send PR to Arnd. > > Separate patches are fine for a short series, it doesn't have > to be a pull request, but do make sure to send it to > soc@kernel.org after review is complete so I'll be sure to > take care of it in patchwork, I otherwise skip a lot of > patches as I expect them to be picked up into a platform > specific tree first. > > Also, if this ends up being a genpd driver, then patches > after 6.6-rc1 need to go through Ulf's tree instead, not > the soc tree. Just to get the ball rolling, I've made the maintainers entry for you Huacai :) Perhaps you can pick up the two patches I mentioned earlier in the thread, as both appear to be fixes? Thanks, Conor. -- >8 -- From 4423897634c0e54274df90a0a933e05f8f78074f Mon Sep 17 00:00:00 2001 From: Conor Dooley <conor.dooley@microchip.com> Date: Tue, 1 Aug 2023 09:08:21 +0100 Subject: [PATCH] MAINTAINERS: add loongson soc driver entry As a result of there being no entry covering Loongson SoC drivers, some fixes have fallen through the cracks. Add Huacai Chen as a supporter of drivers, who will forward patches to the SoC maintainers. Link: https://lore.kernel.org/all/58500dc7-af1b-4edb-bb2b-93be454ec151@app.fastmail.com/ Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3be1bdfe8ecc..0225bf871bab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12250,6 +12250,12 @@ S: Maintained F: Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml F: drivers/i2c/busses/i2c-ls2x.c +LOONGSON SOC DRIVERS +M: Huacai Chen <chenhuacai@kernel.org> +L: loongarch@lists.linux.dev +S: Supported +F: drivers/soc/loongson/ + LOONGSON-2 SOC SERIES CLOCK DRIVER M: Yinbo Zhu <zhuyinbo@loongson.cn> L: linux-clk@vger.kernel.org