| Message ID | 20230801232448.4175662-1-dmitry.baryshkov@linaro.org |
|---|---|
| State | Accepted |
| Commit | b6a56a5a25d6273729b2b5139d58e3d390318ed2 |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: qrb2210-rb1: add wifi variant property | expand |
On 2.08.2023 01:24, Dmitry Baryshkov wrote: > The RB1 platform doesn't have board-specific board-id programmed, it uses > generic 0xff. Thus add the property with the 'variant' of the > calibration data. > > Note: the driver will check for the calibration data for the following > IDs, so existing board-2.bin files will continue to work. > > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=120,variant=Thundercomm_RB1' > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=120' > - 'bus=snoc,qmi-board-id=ff' > > For the reference, the board is identified by the driver in the > following way: > > ath10k_snoc c800000.wifi: qmi chip_id 0x120 chip_family 0x4007 board_id 0xff soc_id 0x40670000 > ath10k_snoc c800000.wifi: qmi fw_version 0x337302d3 fw_build_timestamp 2023-01-06 01:50 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.3.3.7.c2-00723-QCAHLSWMTPLZ-1 > ath10k_snoc c800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000 > ath10k_snoc c800000.wifi: kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0 > ath10k_snoc c800000.wifi: firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790 > ath10k_snoc c800000.wifi: htt-ver 3.114 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1 > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Thundercomm.. Qualcomm.. QTI.. I'm not even sure who makes these boards anymore.. But I guess Thundercomm sells them. Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 2.08.2023 01:24, Dmitry Baryshkov wrote: > The RB2 platform doesn't have board-specific board-id programmed, it uses > generic 0xff. Thus add the property with the 'variant' of the > calibration data. > > Note: the driver will check for the calibration data for the following > IDs, so existing board-2.bin files will continue to work. > > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=150,variant=Thundercomm_RB2' > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=150' > - 'bus=snoc,qmi-board-id=ff' > > For the reference, the board is identified by the driver in the > following way: > > ath10k_snoc c800000.wifi: qmi chip_id 0x150 chip_family 0x4002 board_id 0xff soc_id 0x40670000 > ath10k_snoc c800000.wifi: qmi fw_version 0x337302d3 fw_build_timestamp 2023-01-06 01:50 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.3.3.7.c2-00723-QCAHLSWMTPLZ-1 > ath10k_snoc c800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000 > ath10k_snoc c800000.wifi: kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0 > ath10k_snoc c800000.wifi: firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790 > ath10k_snoc c800000.wifi: htt-ver 3.114 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1 > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Wed, Aug 02, 2023 at 02:24:47AM +0300, Dmitry Baryshkov wrote: > The RB1 platform doesn't have board-specific board-id programmed, it uses > generic 0xff. Thus add the property with the 'variant' of the > calibration data. > I'm not able to find any patches posted that adds the &wifi node in either rb1 or rb2. Can you please have this squashed when that node is added? Regards, Bjorn > Note: the driver will check for the calibration data for the following > IDs, so existing board-2.bin files will continue to work. > > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=120,variant=Thundercomm_RB1' > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=120' > - 'bus=snoc,qmi-board-id=ff' > > For the reference, the board is identified by the driver in the > following way: > > ath10k_snoc c800000.wifi: qmi chip_id 0x120 chip_family 0x4007 board_id 0xff soc_id 0x40670000 > ath10k_snoc c800000.wifi: qmi fw_version 0x337302d3 fw_build_timestamp 2023-01-06 01:50 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.3.3.7.c2-00723-QCAHLSWMTPLZ-1 > ath10k_snoc c800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000 > ath10k_snoc c800000.wifi: kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0 > ath10k_snoc c800000.wifi: firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790 > ath10k_snoc c800000.wifi: htt-ver 3.114 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1 > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts > index 608bb119ff02..166385971d7b 100644 > --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts > +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts > @@ -536,6 +536,7 @@ &wifi { > vdd-1.8-xo-supply = <&pm2250_l13>; > vdd-1.3-rfa-supply = <&pm2250_l10>; > vdd-3.3-ch0-supply = <&pm2250_l22>; > + qcom,ath10k-calibration-variant = "Thundercomm_RB1"; > status = "okay"; > }; > > -- > 2.39.2 >
diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts index 608bb119ff02..166385971d7b 100644 --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts @@ -536,6 +536,7 @@ &wifi { vdd-1.8-xo-supply = <&pm2250_l13>; vdd-1.3-rfa-supply = <&pm2250_l10>; vdd-3.3-ch0-supply = <&pm2250_l22>; + qcom,ath10k-calibration-variant = "Thundercomm_RB1"; status = "okay"; };
The RB1 platform doesn't have board-specific board-id programmed, it uses generic 0xff. Thus add the property with the 'variant' of the calibration data. Note: the driver will check for the calibration data for the following IDs, so existing board-2.bin files will continue to work. - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=120,variant=Thundercomm_RB1' - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=120' - 'bus=snoc,qmi-board-id=ff' For the reference, the board is identified by the driver in the following way: ath10k_snoc c800000.wifi: qmi chip_id 0x120 chip_family 0x4007 board_id 0xff soc_id 0x40670000 ath10k_snoc c800000.wifi: qmi fw_version 0x337302d3 fw_build_timestamp 2023-01-06 01:50 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.3.3.7.c2-00723-QCAHLSWMTPLZ-1 ath10k_snoc c800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000 ath10k_snoc c800000.wifi: kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0 ath10k_snoc c800000.wifi: firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790 ath10k_snoc c800000.wifi: htt-ver 3.114 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1 Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 1 + 1 file changed, 1 insertion(+)