| Message ID | 20230803020939.491-1-guozihua@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | fbcon: Make fbcon_registered_fb and fbcon_num_registered_fb static | expand |
On Thu, Aug 03, 2023 at 10:40:35AM +0200, Daniel Vetter wrote: > On Thu, Aug 03, 2023 at 10:09:39AM +0800, GUO Zihua wrote: > > fbcon_registered_fb and fbcon_num_registered_fb is not referred outside > > drivers/video/fbdev/core/fbcon.c, so make them static. > > > > Signed-off-by: GUO Zihua <guozihua@huawei.com> > > Applied both of your patches to drm-misc-next. Correction, I dropped the agpgart patch again because amd gart x86 arch code needs that symbol. > -Daniel > > > --- > > drivers/video/fbdev/core/fbcon.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > > index 887fad44e7ec..976900d6893c 100644 > > --- a/drivers/video/fbdev/core/fbcon.c > > +++ b/drivers/video/fbdev/core/fbcon.c > > @@ -102,8 +102,8 @@ enum { > > > > static struct fbcon_display fb_display[MAX_NR_CONSOLES]; > > > > -struct fb_info *fbcon_registered_fb[FB_MAX]; > > -int fbcon_num_registered_fb; > > +static struct fb_info *fbcon_registered_fb[FB_MAX]; > > +static int fbcon_num_registered_fb; > > > > #define fbcon_for_each_registered_fb(i) \ > > for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \ > > -- > > 2.17.1 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 887fad44e7ec..976900d6893c 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -102,8 +102,8 @@ enum { static struct fbcon_display fb_display[MAX_NR_CONSOLES]; -struct fb_info *fbcon_registered_fb[FB_MAX]; -int fbcon_num_registered_fb; +static struct fb_info *fbcon_registered_fb[FB_MAX]; +static int fbcon_num_registered_fb; #define fbcon_for_each_registered_fb(i) \ for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \
fbcon_registered_fb and fbcon_num_registered_fb is not referred outside drivers/video/fbdev/core/fbcon.c, so make them static. Signed-off-by: GUO Zihua <guozihua@huawei.com> --- drivers/video/fbdev/core/fbcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)