| Message ID | 1398342509-10243-9-git-send-email-peter.griffin@linaro.org |
|---|---|
| State | Accepted |
| Commit | 05c4cc0f95772364989dd58457e42b0566d1f156 |
| Headers | show |
On Thu, Apr 24, 2014 at 5:28 AM, Peter Griffin <peter.griffin@linaro.org> wrote: > The LM3630A driver cannot be successfully built if we don't > enable the PWM subsystem. This patch makes that dependency > explicit in Kconfig and prevents broken randconfig builds. > > Based on Arnd Bergmann patch but split out into seperate > commits per driver based on feedback. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Cc: Jingoo Han <jg1.han@samsung.com> > Cc: Bryan Wu <cooloney@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/backlight/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 5a3eb2e..4791af7 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -370,7 +370,7 @@ config BACKLIGHT_AAT2870 > > config BACKLIGHT_LM3630A > tristate "Backlight Driver for LM3630A" > - depends on BACKLIGHT_CLASS_DEVICE && I2C > + depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM Looks good to me, Acked-by: Bryan Wu <cooloney@gmail.com> > select REGMAP_I2C > help > This supports TI LM3630A Backlight Driver > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday, April 24, 2014 9:28 PM, Peter Griffin wrote: > > The LM3630A driver cannot be successfully built if we don't > enable the PWM subsystem. This patch makes that dependency > explicit in Kconfig and prevents broken randconfig builds. > > Based on Arnd Bergmann patch but split out into seperate > commits per driver based on feedback. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Cc: Jingoo Han <jg1.han@samsung.com> Acked-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > Cc: Bryan Wu <cooloney@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/backlight/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 5a3eb2e..4791af7 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -370,7 +370,7 @@ config BACKLIGHT_AAT2870 > > config BACKLIGHT_LM3630A > tristate "Backlight Driver for LM3630A" > - depends on BACKLIGHT_CLASS_DEVICE && I2C > + depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM > select REGMAP_I2C > help > This supports TI LM3630A Backlight Driver > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
> The LM3630A driver cannot be successfully built if we don't > enable the PWM subsystem. This patch makes that dependency > explicit in Kconfig and prevents broken randconfig builds. > > Based on Arnd Bergmann patch but split out into seperate > commits per driver based on feedback. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Cc: Jingoo Han <jg1.han@samsung.com> > Cc: Bryan Wu <cooloney@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/backlight/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied thanks.
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 5a3eb2e..4791af7 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -370,7 +370,7 @@ config BACKLIGHT_AAT2870 config BACKLIGHT_LM3630A tristate "Backlight Driver for LM3630A" - depends on BACKLIGHT_CLASS_DEVICE && I2C + depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM select REGMAP_I2C help This supports TI LM3630A Backlight Driver