| Message ID | 20230810153640.1879717-1-alex.bennee@linaro.org |
|---|---|
| Headers | show |
| Series | some testing and gdbstub fixes | expand |
On 10/8/23 17:36, Alex Bennée wrote: > When starting a remote connection GDB sends an '+': > > /* Ack any packet which the remote side has already sent. */ > remote_serial_write ("+", 1); > > which gets flagged as a garbage character in the gdbstub state > machine. As gdb does send it out lets be permissive about the handling > so we can better see real issues. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: gdb-patches@sourceware.org > --- > gdbstub/gdbstub.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Thu, 10 Aug 2023 at 16:36, Alex Bennée <alex.bennee@linaro.org> wrote: > > This is mostly gdbstub focused but I cleaned up some bits while I was > in the testing makefiles. This is mostly to make the "check-tcg" > output as clean as possible without ugly line wraps. I tried to > eliminate the gdbstub info() output but sadly this is harder than > expected. > > I've tweaked the gdbstub handling for Ctrl-c packets as suggested by > Matheus. While I was there I also noticed we were being a bit precious > about gdb sending preemptive ACKS so I fixed that as well. > > I don't know if this is all late 8.1-rc material but its fairly simple > testing updates and the ccache stuff from Daniel should help as well. At this point in the cycle I would favour putting in the minimum that actually fixes bugs / test failure issues. thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Thu, 10 Aug 2023 at 16:36, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> This is mostly gdbstub focused but I cleaned up some bits while I was >> in the testing makefiles. This is mostly to make the "check-tcg" >> output as clean as possible without ugly line wraps. I tried to >> eliminate the gdbstub info() output but sadly this is harder than >> expected. >> >> I've tweaked the gdbstub handling for Ctrl-c packets as suggested by >> Matheus. While I was there I also noticed we were being a bit precious >> about gdb sending preemptive ACKS so I fixed that as well. >> >> I don't know if this is all late 8.1-rc material but its fairly simple >> testing updates and the ccache stuff from Daniel should help as well. > > At this point in the cycle I would favour putting in > the minimum that actually fixes bugs / test failure issues. So 7 and 8? I would argue for 6 as well given that's a foot gun just waiting to happen. > > thanks > -- PMM
On 8/10/23 08:58, Peter Maydell wrote: > On Thu, 10 Aug 2023 at 16:36, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> This is mostly gdbstub focused but I cleaned up some bits while I was >> in the testing makefiles. This is mostly to make the "check-tcg" >> output as clean as possible without ugly line wraps. I tried to >> eliminate the gdbstub info() output but sadly this is harder than >> expected. >> >> I've tweaked the gdbstub handling for Ctrl-c packets as suggested by >> Matheus. While I was there I also noticed we were being a bit precious >> about gdb sending preemptive ACKS so I fixed that as well. >> >> I don't know if this is all late 8.1-rc material but its fairly simple >> testing updates and the ccache stuff from Daniel should help as well. > > At this point in the cycle I would favour putting in > the minimum that actually fixes bugs / test failure issues. Indeed. Which I think would be patches 7 and 8. r~
On 8/10/23 09:35, Alex Bennée wrote: > So 7 and 8? I would argue for 6 as well given that's a foot gun just > waiting to happen. Yes, the timing issues with 6 are nasty. r~
On 8/10/23 09:43, Richard Henderson wrote: > On 8/10/23 09:35, Alex Bennée wrote: >> So 7 and 8? I would argue for 6 as well given that's a foot gun just >> waiting to happen. > > Yes, the timing issues with 6 are nasty. I'm going to queue 6-8 to tcg-next, along with the %x change Phil suggested for logging non-ASCII characters. r~