| Message ID | 20230831225607.30829-11-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | (few more) Steps towards enabling -Wshadow | expand |
On 2023/09/01 7:56, Philippe Mathieu-Daudé wrote: > Fix: > > net/eth.c:435:20: error: declaration shadows a local variable [-Werror,-Wshadow] > size_t input_size = iov_size(pkt, pkt_frags); > ^ > net/eth.c:413:16: note: previous declaration is here > size_t input_size = iov_size(pkt, pkt_frags); > ^ > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > net/eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/eth.c b/net/eth.c > index 649e66bb1f..cf030eed7b 100644 > --- a/net/eth.c > +++ b/net/eth.c > @@ -432,7 +432,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int pkt_frags, > } > > if (opthdr.type == IP6_OPT_HOME) { > - size_t input_size = iov_size(pkt, pkt_frags); > + input_size = iov_size(pkt, pkt_frags); You can just remove this statement. > > if (input_size < opt_offset + sizeof(opthdr)) { > return false;
On 1/9/23 09:07, Akihiko Odaki wrote: > On 2023/09/01 7:56, Philippe Mathieu-Daudé wrote: >> Fix: >> >> net/eth.c:435:20: error: declaration shadows a local variable >> [-Werror,-Wshadow] >> size_t input_size = iov_size(pkt, pkt_frags); >> ^ >> net/eth.c:413:16: note: previous declaration is here >> size_t input_size = iov_size(pkt, pkt_frags); >> ^ >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >> --- >> net/eth.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/eth.c b/net/eth.c >> index 649e66bb1f..cf030eed7b 100644 >> --- a/net/eth.c >> +++ b/net/eth.c >> @@ -432,7 +432,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, >> int pkt_frags, >> } >> if (opthdr.type == IP6_OPT_HOME) { >> - size_t input_size = iov_size(pkt, pkt_frags); >> + input_size = iov_size(pkt, pkt_frags); > > You can just remove this statement. Clever eh, thanks!
diff --git a/net/eth.c b/net/eth.c index 649e66bb1f..cf030eed7b 100644 --- a/net/eth.c +++ b/net/eth.c @@ -432,7 +432,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int pkt_frags, } if (opthdr.type == IP6_OPT_HOME) { - size_t input_size = iov_size(pkt, pkt_frags); + input_size = iov_size(pkt, pkt_frags); if (input_size < opt_offset + sizeof(opthdr)) { return false;
Fix: net/eth.c:435:20: error: declaration shadows a local variable [-Werror,-Wshadow] size_t input_size = iov_size(pkt, pkt_frags); ^ net/eth.c:413:16: note: previous declaration is here size_t input_size = iov_size(pkt, pkt_frags); ^ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- net/eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)