| Message ID | 20230602062016.1883171-6-abel.vesa@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/6] arm64: dts: qcom: sm8150: Use 2 interconnect cells | expand |
Hi, On 02/06/2023 08:20, Abel Vesa wrote: > The USB HC node is missing the interconnect paths, so add them. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > > Changes since v1: > * Added Konrad's R-b tag > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 11560ec9f182..5cd7296c7660 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -4306,6 +4306,10 @@ usb_1: usb@a6f8800 { > > resets = <&gcc GCC_USB30_PRIM_BCR>; > > + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; > + interconnect-names = "usb-ddr", "apps-usb"; > + > usb_1_dwc3: usb@a600000 { > compatible = "snps,dwc3"; > reg = <0 0x0a600000 0 0xcd00>; Since this commit, this happens on hdk8450: [ 0.280395] usb30_prim_gdsc status stuck at 'off' # bad: [2dde18cd1d8fac735875f2e4987f11817cc0bc2c] Linux 6.5 # good: [6995e2de6891c724bfeb2db33d7b87775f913ad1] Linux 6.4 git bisect start 'v6.5' 'v6.4' # good: [b775d6c5859affe00527cbe74263de05cfe6b9f9] Merge tag 'mips_6.5' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux git bisect good b775d6c5859affe00527cbe74263de05cfe6b9f9 # bad: [56cbceab928d7ac3702de172ff8dcc1da2a6aaeb] Merge tag 'usb-6.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb git bisect bad 56cbceab928d7ac3702de172ff8dcc1da2a6aaeb # bad: [b30d7a77c53ec04a6d94683d7680ec406b7f3ac8] Merge tag 'perf-tools-for-v6.5-1-2023-06-28' of git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next git bisect bad b30d7a77c53ec04a6d94683d7680ec406b7f3ac8 # bad: [313c22bb31953c5ac7f3be94279126307dd5865c] Merge tag 'arm-soc/for-6.5/devicetree' of https://github.com/Broadcom/stblinux into soc/dt git bisect bad 313c22bb31953c5ac7f3be94279126307dd5865c # good: [60c2f542a7ada6bce82ce8e9d50e05eea74fe472] Merge tag 'qcom-arm64-for-6.5' of https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux into soc/dt git bisect good 60c2f542a7ada6bce82ce8e9d50e05eea74fe472 # good: [af3c684721cf69ff662c53a58f02261fa2f8efbe] Merge tag 'ti-k3-dt-for-v6.5' of https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux into soc/dt git bisect good af3c684721cf69ff662c53a58f02261fa2f8efbe # bad: [f07c96511d00138171130d43a50a377489cd87de] Merge tag 'v6.4-next-dts32' of https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux into soc/dt git bisect bad f07c96511d00138171130d43a50a377489cd87de # good: [abc49a7c6035c57ece0642811f70a7a3892badb6] dt-bindings: arm: qcom: Add Samsung Galaxy Express git bisect good abc49a7c6035c57ece0642811f70a7a3892badb6 # bad: [e47a7f571d57d383f345e85c47a05ef1801b278c] arm64: dts: qcom: sm8250: rename labels for DSI nodes git bisect bad e47a7f571d57d383f345e85c47a05ef1801b278c # bad: [add687cbfc3482ca74949b91b251e76792d25652] dt-bindings: arm: qcom: document AL02-C9 board based on IPQ9574 family git bisect bad add687cbfc3482ca74949b91b251e76792d25652 # good: [fd62fd1cf9e7fb7ef761e411d37cb5d06769954b] arm64: dts: qcom: sm8250: Add missing interconnect paths to USB HCs git bisect good fd62fd1cf9e7fb7ef761e411d37cb5d06769954b # bad: [90c8c4eb4bbb5e2e241fd5286bd43dd30a850b9d] arm64: dts: qcom: qdu1000: Add SDHCI node git bisect bad 90c8c4eb4bbb5e2e241fd5286bd43dd30a850b9d # bad: [b5b0649d5be4c82d09489492c121a7823323fc4a] arm64: dts: qcom: sm8450: Add missing interconnect paths to USB HC git bisect bad b5b0649d5be4c82d09489492c121a7823323fc4a # good: [8b51dc863baf1447e9ab52411c5bed7ef9a56d80] arm64: dts: qcom: sm8350: Add missing interconnect paths to USB HCs git bisect good 8b51dc863baf1447e9ab52411c5bed7ef9a56d80 # first bad commit: [b5b0649d5be4c82d09489492c121a7823323fc4a] arm64: dts: qcom: sm8450: Add missing interconnect paths to USB HC Neil
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 11560ec9f182..5cd7296c7660 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -4306,6 +4306,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;