mbox series

[V4,0/2] Add Phy Configuration support for SC7280

Message ID 20230918205037.25658-1-quic_nitirawa@quicinc.com
Headers show
Series Add Phy Configuration support for SC7280 | expand

Message

Nitin Rawat Sept. 18, 2023, 8:50 p.m. UTC 
This patch adds Phy configuration support for Qualcomm SC7280 SOC.

Changes from v3:
- Addressed dmitry comment to update correct binding for clk entry

Changes from V2:
- Addressed Vinod comment to replace upper case character with lower case

Changes from V1:
- Addressed dmitry's comment to align sc7280 register arrays in sorted order
- Addressed konrad & vinod's comment to align phy compatible in sorted order

Nitin Rawat (2):
  dt-bindings: phy: Add QMP UFS PHY comptible for SC7280
  phy: qcom-qmp-ufs: Add Phy Configuration support for SC7280

 .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml        |   2 +
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c       | 142 ++++++++++++++++++
 2 files changed, 144 insertions(+)

--
2.17.1

Comments

Conor Dooley Sept. 19, 2023, 8:48 a.m. UTC | #1 
On Tue, Sep 19, 2023 at 02:20:36AM +0530, Nitin Rawat wrote:
> Document the QMP UFS PHY compatible for SC7280.
> 
> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
> ---
>  .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml      | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> index d981d77e82e4..f3a3296c811c 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> @@ -19,6 +19,7 @@ properties:
>        - qcom,msm8996-qmp-ufs-phy
>        - qcom,msm8998-qmp-ufs-phy
>        - qcom,sa8775p-qmp-ufs-phy
> +      - qcom,sc7280-qmp-ufs-phy
>        - qcom,sc8180x-qmp-ufs-phy
>        - qcom,sc8280xp-qmp-ufs-phy
>        - qcom,sdm845-qmp-ufs-phy
> @@ -85,6 +86,7 @@ allOf:
>            contains:
>              enum:
>                - qcom,sa8775p-qmp-ufs-phy
> +              - qcom,sc7280-qmp-ufs-phy
>                - qcom,sm8450-qmp-ufs-phy
>      then:
>        properties:
> --
> 2.17.1
>
Dmitry Baryshkov Sept. 19, 2023, 3:12 p.m. UTC | #2 
On Mon, 18 Sept 2023 at 23:51, Nitin Rawat <quic_nitirawa@quicinc.com> wrote:
>
> Add SC7280 specific register layout and table configs.
>
> Co-developed-by: Manish Pandey <quic_mapa@quicinc.com>
> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Vinod Koul Sept. 21, 2023, 2:29 p.m. UTC | #3 
On Tue, 19 Sep 2023 02:20:35 +0530, Nitin Rawat wrote:
> This patch adds Phy configuration support for Qualcomm SC7280 SOC.
> 
> Changes from v3:
> - Addressed dmitry comment to update correct binding for clk entry
> 
> Changes from V2:
> - Addressed Vinod comment to replace upper case character with lower case
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: phy: Add QMP UFS PHY comptible for SC7280
      commit: 79eeac2e262545077be482b1a1700669e0c7d90c
[2/2] phy: qcom-qmp-ufs: Add Phy Configuration support for SC7280
      commit: 8abe9792d1ff7e60f911b56e8a2537be7e903576

Best regards,