| Message ID | 16a9ad33ef67993482da0d350d7239aee3f0dd22.1697400022.git.anonolitunya@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | staging: sm750fb: Renaming camelcase to snakecase | expand |
On Sun, 15 Oct 2023, Dorcas AnonoLitunya wrote: > Rename function displayControlAdjust_SM750E to > display_control_adjust_SM750E.This follows snakecase naming convention > and ensures consistent naming style throughout the file.Issue by > checkpatch. The period at the end of a sentence should have a space after it. ensures -> ensures a Issue -> Issue found julia > > Mutes the following error: > CHECK:Avoid CamelCase: <displayControlAdjust_SM750E> > > Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> > --- > drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c > index e00a6cb31947..8708995f676c 100644 > --- a/drivers/staging/sm750fb/ddk750_mode.c > +++ b/drivers/staging/sm750fb/ddk750_mode.c > @@ -14,8 +14,8 @@ > * in bit 29:27 of Display Control register. > */ > static unsigned long > -displayControlAdjust_SM750LE(struct mode_parameter *pModeParam, > - unsigned long dispControl) > +display_control_adjust_SM750LE(struct mode_parameter *pModeParam, > + unsigned long dispControl) > { > unsigned long x, y; > > @@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam, > tmp |= DISPLAY_CTRL_HSYNC_PHASE; > > if (sm750_get_chip_type() == SM750LE) { > - displayControlAdjust_SM750LE(pModeParam, tmp); > + display_control_adjust_SM750LE(pModeParam, tmp); > } else { > reg = peek32(CRT_DISPLAY_CTRL) & > ~(DISPLAY_CTRL_VSYNC_PHASE | > -- > 2.42.0.345.gaab89be2eb > > >
On Sun, Oct 15, 2023 at 10:22:29PM +0200, Julia Lawall wrote: > > > On Sun, 15 Oct 2023, Dorcas AnonoLitunya wrote: > > > Rename function displayControlAdjust_SM750E to > > display_control_adjust_SM750E.This follows snakecase naming convention > > and ensures consistent naming style throughout the file.Issue by > > checkpatch. > > The period at the end of a sentence should have a space after it. > > ensures -> ensures a > > Issue -> Issue found > This is corrected. Thanks Julia! > julia > > > > > Mutes the following error: > > CHECK:Avoid CamelCase: <displayControlAdjust_SM750E> > > > > Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> > > --- > > drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c > > index e00a6cb31947..8708995f676c 100644 > > --- a/drivers/staging/sm750fb/ddk750_mode.c > > +++ b/drivers/staging/sm750fb/ddk750_mode.c > > @@ -14,8 +14,8 @@ > > * in bit 29:27 of Display Control register. > > */ > > static unsigned long > > -displayControlAdjust_SM750LE(struct mode_parameter *pModeParam, > > - unsigned long dispControl) > > +display_control_adjust_SM750LE(struct mode_parameter *pModeParam, > > + unsigned long dispControl) > > { > > unsigned long x, y; > > > > @@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam, > > tmp |= DISPLAY_CTRL_HSYNC_PHASE; > > > > if (sm750_get_chip_type() == SM750LE) { > > - displayControlAdjust_SM750LE(pModeParam, tmp); > > + display_control_adjust_SM750LE(pModeParam, tmp); > > } else { > > reg = peek32(CRT_DISPLAY_CTRL) & > > ~(DISPLAY_CTRL_VSYNC_PHASE | > > -- > > 2.42.0.345.gaab89be2eb > > > > > >
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index e00a6cb31947..8708995f676c 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -14,8 +14,8 @@ * in bit 29:27 of Display Control register. */ static unsigned long -displayControlAdjust_SM750LE(struct mode_parameter *pModeParam, - unsigned long dispControl) +display_control_adjust_SM750LE(struct mode_parameter *pModeParam, + unsigned long dispControl) { unsigned long x, y; @@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam, tmp |= DISPLAY_CTRL_HSYNC_PHASE; if (sm750_get_chip_type() == SM750LE) { - displayControlAdjust_SM750LE(pModeParam, tmp); + display_control_adjust_SM750LE(pModeParam, tmp); } else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE |
Rename function displayControlAdjust_SM750E to display_control_adjust_SM750E.This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch. Mutes the following error: CHECK:Avoid CamelCase: <displayControlAdjust_SM750E> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> --- drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)