mbox series

[00/46] fbdev: Init fb_ops with helpers for I/O memory

Message ID 20230927074722.6197-1-tzimmermann@suse.de
Headers show
Series fbdev: Init fb_ops with helpers for I/O memory | expand

Message

Thomas Zimmermann Sept. 27, 2023, 7:26 a.m. UTC 
Initialize struct fb_ops for drivers for hardware with framebuffers
in I/O-memory ranges with the respective helper macros. Also select
the appropriate Kconfig dependencies.

The patchset is part of a larger effort to modularize the fbdev core
and make it more adaptable. Most of these drivers do not initialize
the fb_read, fb_write and fb_mmap callbacks in fb_ops. By leaving the
callback pointers to NULL, they rely on the fbdev core to invoke the
I/O-memory helpers by default. This default makes it impossible to
remove the I/O-memory helpers on systems that don't need them. Setting
the pointers explicitly will allow for the removal of the default. If
a callback in fb_ops is unset, the operation will then be unsupported.

Initializing struct fb_ops via helpers macros will also allow for a
fine-grained setup, depending on Kconfig options. For example, it
will be possible to leave out file I/O if FB_DEVICE has not been
set.

This patchset contains the majority of fbdev driver work. The updated
drivers now initialize fb_ops with __FB_DEFAULT_IOMEM_OPS_RDWR,
__FB_DEFAULT_IOMEM_OPS_DRAW and/or __FB_DEFAULT_IOMEM_OPS_MMAP if
possible. Some drivers now use FB_DEFAULT_IOMEM_OPS, which sets all
fields correctly. In Kconfig, each driver selects FB_IOMEM_FOPS to
get the helpers for I/O memory. Drivers that use _RDWR, _DRAW and
_MMAP unconditionally select FB_IOMEM_HELPERS, which selects the
correct modules automatically.

Thomas Zimmermann (46):
  fbdev: Provide I/O-memory helpers as module
  fbdev/68328fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/amba-clcd: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/amifb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/arkfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/atafb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/atyfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/au1100fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/cirrusfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/cobalt-lcd: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/controlfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/cyber2000fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/dnfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/ep93xx-fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/gbefb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/hgafb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/hitfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/hpfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/i810fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/imsttfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/intelfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/matroxfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/neofb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/nvidiafb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/omapfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/pm2fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/pm3fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/pvr2fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/radeon: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/rivafb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/s1d13xxxfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/s3fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/sa1100fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/savagefb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/sisfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/sm501fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/sm712fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/stifb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/sunxvr500: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/tdfxfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/tgafb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/tridentfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/vermilionfb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/vga16fb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/viafb: Initialize fb_ops to fbdev I/O-memory helpers
  fbdev/vt8623fb: Initialize fb_ops to fbdev I/O-memory helpers

 drivers/video/fbdev/68328fb.c                 |  5 +-
 drivers/video/fbdev/Kconfig                   | 93 +++++++++++--------
 drivers/video/fbdev/amba-clcd.c               |  5 +-
 drivers/video/fbdev/amifb.c                   |  2 +
 drivers/video/fbdev/arkfb.c                   |  2 +
 drivers/video/fbdev/atafb.c                   |  2 +
 drivers/video/fbdev/aty/atyfb_base.c          |  3 +
 drivers/video/fbdev/aty/radeon_base.c         |  2 +
 drivers/video/fbdev/au1100fb.c                |  8 +-
 drivers/video/fbdev/cirrusfb.c                |  2 +
 drivers/video/fbdev/cobalt_lcdfb.c            |  2 +
 drivers/video/fbdev/controlfb.c               |  5 +-
 drivers/video/fbdev/core/Kconfig              |  6 ++
 drivers/video/fbdev/core/Makefile             |  3 +-
 drivers/video/fbdev/core/fb_io_fops.c         |  3 +
 drivers/video/fbdev/cyber2000fb.c             |  2 +
 drivers/video/fbdev/dnfb.c                    |  2 +
 drivers/video/fbdev/ep93xx-fb.c               |  5 +-
 drivers/video/fbdev/gbefb.c                   |  7 +-
 drivers/video/fbdev/hgafb.c                   |  2 +
 drivers/video/fbdev/hitfb.c                   |  4 +-
 drivers/video/fbdev/hpfb.c                    |  2 +
 drivers/video/fbdev/i810/i810_main.c          |  2 +
 drivers/video/fbdev/imsttfb.c                 |  2 +
 drivers/video/fbdev/intelfb/intelfbdrv.c      |  4 +-
 drivers/video/fbdev/matrox/matroxfb_base.c    |  2 +
 drivers/video/fbdev/matrox/matroxfb_crtc2.c   |  4 +-
 drivers/video/fbdev/neofb.c                   |  2 +
 drivers/video/fbdev/nvidia/nvidia.c           |  2 +
 drivers/video/fbdev/omap2/omapfb/Kconfig      |  4 +-
 .../video/fbdev/omap2/omapfb/omapfb-main.c    |  5 +-
 drivers/video/fbdev/pm2fb.c                   |  2 +
 drivers/video/fbdev/pm3fb.c                   |  2 +
 drivers/video/fbdev/pvr2fb.c                  | 14 +--
 drivers/video/fbdev/riva/fbdev.c              |  2 +
 drivers/video/fbdev/s1d13xxxfb.c              | 25 +++--
 drivers/video/fbdev/s3fb.c                    |  2 +
 drivers/video/fbdev/sa1100fb.c                |  5 +-
 drivers/video/fbdev/savage/savagefb_driver.c  |  6 +-
 drivers/video/fbdev/sis/sis_main.c            |  4 +-
 drivers/video/fbdev/sm501fb.c                 |  4 +
 drivers/video/fbdev/sm712fb.c                 |  1 +
 drivers/video/fbdev/stifb.c                   |  2 +
 drivers/video/fbdev/sunxvr500.c               |  2 +
 drivers/video/fbdev/tdfxfb.c                  |  6 +-
 drivers/video/fbdev/tgafb.c                   |  2 +
 drivers/video/fbdev/tridentfb.c               |  2 +
 drivers/video/fbdev/vermilion/vermilion.c     |  5 +-
 drivers/video/fbdev/vga16fb.c                 |  2 +
 drivers/video/fbdev/via/viafbdev.c            |  2 +
 drivers/video/fbdev/vt8623fb.c                |  2 +
 51 files changed, 185 insertions(+), 101 deletions(-)


base-commit: e1973de2c4516e9130157e538014e79c8aa57b41
prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: cbc453ee02fae02af22fbfdce56ab732c7a88c36

Comments

Javier Martinez Canillas Oct. 18, 2023, 8:25 a.m. UTC | #1 
Thomas Zimmermann <tzimmermann@suse.de> writes:

> Initialize struct fb_ops for drivers for hardware with framebuffers
> in I/O-memory ranges with the respective helper macros. Also select
> the appropriate Kconfig dependencies.
>
> The patchset is part of a larger effort to modularize the fbdev core
> and make it more adaptable. Most of these drivers do not initialize
> the fb_read, fb_write and fb_mmap callbacks in fb_ops. By leaving the
> callback pointers to NULL, they rely on the fbdev core to invoke the
> I/O-memory helpers by default. This default makes it impossible to
> remove the I/O-memory helpers on systems that don't need them. Setting
> the pointers explicitly will allow for the removal of the default. If
> a callback in fb_ops is unset, the operation will then be unsupported.
>
> Initializing struct fb_ops via helpers macros will also allow for a
> fine-grained setup, depending on Kconfig options. For example, it
> will be possible to leave out file I/O if FB_DEVICE has not been
> set.
>
> This patchset contains the majority of fbdev driver work. The updated
> drivers now initialize fb_ops with __FB_DEFAULT_IOMEM_OPS_RDWR,
> __FB_DEFAULT_IOMEM_OPS_DRAW and/or __FB_DEFAULT_IOMEM_OPS_MMAP if
> possible. Some drivers now use FB_DEFAULT_IOMEM_OPS, which sets all
> fields correctly. In Kconfig, each driver selects FB_IOMEM_FOPS to
> get the helpers for I/O memory. Drivers that use _RDWR, _DRAW and
> _MMAP unconditionally select FB_IOMEM_HELPERS, which selects the
> correct modules automatically.
>

I looked to all the driver changes as well and couldn't spot any issues.
For all the driver patches:

Acked-by: Javier Martinez Canillas <javierm@redhat.com>