diff mbox series

[v2,1/2] dt-bindings: arm: qcom: Add Xiaomi Pad 6 (xiaomi-pipa)

Message ID 20231021173317.185460-1-lukapanio@gmail.com
State Superseded
Headers show
Series [v2,1/2] dt-bindings: arm: qcom: Add Xiaomi Pad 6 (xiaomi-pipa) | expand

Commit Message

Luka Panio Oct. 21, 2023, 5:33 p.m. UTC
Add a compatible for Xiaomi Pad 6.

Signed-off-by: luka177 <lukapanio@gmail.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg Kroah-Hartman Oct. 21, 2023, 7:20 p.m. UTC | #1
On Sat, Oct 21, 2023 at 07:33:17PM +0200, luka177 wrote:
> Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
> 
> Signed-off-by: luka177 <lukapanio@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/sm8250-xiaomi-pipa.dts      | 625 ++++++++++++++++++
>  2 files changed, 626 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- It looks like you did not use your name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
Greg Kroah-Hartman Oct. 21, 2023, 7:59 p.m. UTC | #2
On Sat, Oct 21, 2023 at 09:37:16PM +0200, Лука Паньо wrote:
> This is a new version, but there is no change for dt-bindings part.

Then you must document this.

> As for
> "From:" submitting-patches.rst: "Note, the From: tag is optional when the
> From: author is also the person (and
> email) listed in the From: line of the email header."

Your patch had numbers in the name, but not here, so please use what you
have used here in this email, "Лука Паньо" and you should be fine,
right?

thanks,

greg k-h
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index adbfaea32343..1bfae1b237d2 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -965,6 +965,7 @@  properties:
               - sony,pdx203-generic
               - sony,pdx206-generic
               - xiaomi,elish
+              - xiaomi,pipa
           - const: qcom,sm8250
 
       - items: