| Message ID | 20231017101636.62755-1-raymondhackley@protonmail.com |
|---|---|
| State | Accepted |
| Commit | 25e20eedc1d63dcdf6f781588e8dbc37cd0aad16 |
| Headers | show |
| Series | ARM: dts: samsung: exynos4412-midas: fix key-ok and use Linux event codes | expand |
On 17/10/2023 12:18, Raymond Hackley wrote: > Input event code 139 stands for KEY_MENU, instead of KEY_OK as node name > key-ok inplies. Fix it with correct event code 0x160. > > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com> > --- > arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi > index 7daf25865551..3c1ae3c19828 100644 > --- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi > @@ -159,7 +159,7 @@ key-power { > > key-ok { > gpios = <&gpx0 1 GPIO_ACTIVE_LOW>; > - linux,code = <139>; > + linux,code = <0x160>; I applied this and was about to send in pull request, but it does not seem right, sorry. The button was always called "menu" button. Why changing it to OK? Just because of node name? The node name does not matter, this could be called "key-1" as well.. Best regards, Krzysztof
Hi Krzysztof, This key-ok is the hardware middle button on midas, and there is also touchkey, which already provides <KEY_BACK KEY_MENU>, so I assume the other KEY_MENU in key-ok is duplicated. Fixing it with KEY_OK as the node name implies would make more sense. Regards, Raymond
On 24/10/2023 14:37, Raymond Hackley wrote: > Hi Krzysztof, > > This key-ok is the hardware middle button on midas, and there is also > touchkey, which already provides <KEY_BACK KEY_MENU>, so I assume the other > KEY_MENU in key-ok is duplicated. Fixing it with KEY_OK as the node name > implies would make more sense. Ah, ok, that makes sense. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi index 7daf25865551..3c1ae3c19828 100644 --- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi @@ -159,7 +159,7 @@ key-power { key-ok { gpios = <&gpx0 1 GPIO_ACTIVE_LOW>; - linux,code = <139>; + linux,code = <0x160>; label = "ok"; debounce-interval = <10>; wakeup-source;
Input event code 139 stands for KEY_MENU, instead of KEY_OK as node name key-ok inplies. Fix it with correct event code 0x160. Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com> --- arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)