[v2,08/19] elf: Emit warning if tunable is ill-formatted

Message ID	20231017130526.2216827-9-adhemerval.zanella@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BFF4385697B From: Adhemerval Zanella <adhemerval.zanella@linaro.org> To: libc-alpha@sourceware.org, Siddhesh Poyarekar <siddhesh@sourceware.org> Subject: [PATCH v2 08/19] elf: Emit warning if tunable is ill-formatted Date: Tue, 17 Oct 2023 10:05:15 -0300 Message-Id: <20231017130526.2216827-9-adhemerval.zanella@linaro.org> In-Reply-To: <20231017130526.2216827-1-adhemerval.zanella@linaro.org> References: <20231017130526.2216827-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: libc-alpha-bounces+patch=linaro.org@sourceware.org
Series	Improve loader environment variable handling \| expand [v2,00/19] Improve loader environment variable handling [v2,01/19] elf: Remove /etc/suid-debug support [v2,02/19] elf: Add GLIBC_TUNABLES to unsecvars [v2,03/19] elf: Ignore GLIBC_TUNABLES for setuid/setgid binaries [v2,04/19] elf: Add all malloc tunable to unsecvars [v2,05/19] elf: Do not process invalid tunable format [v2,06/19] elf: Do not parse ill-formatted strings [v2,07/19] elf: Fix _dl_debug_vdprintf to work before self-relocation [v2,08/19] elf: Emit warning if tunable is ill-formatted [v2,09/19] x86: Use dl-symbol-redir-ifunc.h on cpu-tunables [v2,10/19] s390: Use dl-symbol-redir-ifunc.h on cpu-tunables [v2,11/19] elf: Do not duplicate the GLIBC_TUNABLES string [v2,12/19] elf: Ignore LD_PROFILE for setuid binaries [v2,13/19] elf: Remove LD_PROFILE for static binaries [v2,14/19] elf: Ignore loader debug env vars for setuid [v2,15/19] elf: Remove any_debug from dl_main_state [v2,16/19] elf: Ignore LD_LIBRARY_PATH and debug env var for setuid for static [v2,17/19] elf: Add comments on how LD_AUDIT and LD_PRELOAD handle __libc_enable_secure [v2,18/19] elf: Ignore LD_BIND_NOW and LD_BIND_NOT for setuid binaries [v2,19/19] elf: Refactor process_envvars

Message ID

20231017130526.2216827-9-adhemerval.zanella@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
 libc-alpha-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as
 permitted sender) client-ip=8.43.85.97;
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BFF4385697B
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org,
	Siddhesh Poyarekar <siddhesh@sourceware.org>
Subject: [PATCH v2 08/19] elf: Emit warning if tunable is ill-formatted
Date: Tue, 17 Oct 2023 10:05:15 -0300
Message-Id: <20231017130526.2216827-9-adhemerval.zanella@linaro.org>
In-Reply-To: <20231017130526.2216827-1-adhemerval.zanella@linaro.org>
References: <20231017130526.2216827-1-adhemerval.zanella@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: libc-alpha-bounces+patch=linaro.org@sourceware.org

Series

Improve loader environment variable handling | expand

Comments

Siddhesh Poyarekar Oct. 27, 2023, 10:28 a.m. UTC | #1

On 2023-10-17 09:05, Adhemerval Zanella wrote:
> So caller knows that the tunable will be ignored.
> 
> Checked on x86_64-linux-gnu.
> ---
>   elf/dl-tunables.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c
> index 5d4b8c5bc0..b39c14694c 100644
> --- a/elf/dl-tunables.c
> +++ b/elf/dl-tunables.c
> @@ -236,7 +236,11 @@ parse_tunables (char *valstring)
>     struct tunable_toset_t tunables[tunables_list_size];
>     int ntunables = parse_tunables_string (valstring, tunables);
>     if (ntunables == -1)
> -    return;
> +    {
> +      _dl_error_printf (
> +        "ERROR: ld.so: invalid GLIBC_TUNABLES `%s': ignored.\n", valstring);

If it's a warning, then we should say WARNING here.

> +      return;
> +    }
>   
>     for (int i = 0; i < ntunables; i++)
>       tunable_initialize (tunables[i].t, tunables[i].value);

Adhemerval Zanella Oct. 27, 2023, 12:51 p.m. UTC | #2

On 27/10/23 07:28, Siddhesh Poyarekar wrote:
> 
> 
> On 2023-10-17 09:05, Adhemerval Zanella wrote:
>> So caller knows that the tunable will be ignored.
>>
>> Checked on x86_64-linux-gnu.
>> ---
>>   elf/dl-tunables.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c
>> index 5d4b8c5bc0..b39c14694c 100644
>> --- a/elf/dl-tunables.c
>> +++ b/elf/dl-tunables.c
>> @@ -236,7 +236,11 @@ parse_tunables (char *valstring)
>>     struct tunable_toset_t tunables[tunables_list_size];
>>     int ntunables = parse_tunables_string (valstring, tunables);
>>     if (ntunables == -1)
>> -    return;
>> +    {
>> +      _dl_error_printf (
>> +        "ERROR: ld.so: invalid GLIBC_TUNABLES `%s': ignored.\n", valstring);
> 
> If it's a warning, then we should say WARNING here.

Ack.

> 
>> +      return;
>> +    }
>>       for (int i = 0; i < ntunables; i++)
>>       tunable_initialize (tunables[i].t, tunables[i].value);

diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c
index 5d4b8c5bc0..b39c14694c 100644
--- a/elf/dl-tunables.c
+++ b/elf/dl-tunables.c
@@ -236,7 +236,11 @@  parse_tunables (char *valstring)
   struct tunable_toset_t tunables[tunables_list_size];
   int ntunables = parse_tunables_string (valstring, tunables);
   if (ntunables == -1)
-    return;
+    {
+      _dl_error_printf (
+        "ERROR: ld.so: invalid GLIBC_TUNABLES `%s': ignored.\n", valstring);
+      return;
+    }
 
   for (int i = 0; i < ntunables; i++)
     tunable_initialize (tunables[i].t, tunables[i].value);

[v2,08/19] elf: Emit warning if tunable is ill-formatted

Commit Message

Comments

Patch