Message ID | 20231123220841.909656-1-deborah.brouwer@collabora.com |
---|---|
State | Accepted |
Commit | 3b8551e73271fc375b15c887db54ad31686eb2ea |
Headers | show |
Series | media: wave5: add OF and V4L_MEM2MEM_DRIVERS dependencies | expand |
Hi Deb, On 23/11/2023 23:08, Deborah Brouwer wrote: > Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com> > --- > Hi Hans, > Sorry about that - can you please squash this into the series? > > Thanks, > Deborah > > drivers/media/platform/chips-media/wave5/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/chips-media/wave5/Kconfig b/drivers/media/platform/chips-media/wave5/Kconfig > index a3b949356cd5..77e7ae5c8f35 100644 > --- a/drivers/media/platform/chips-media/wave5/Kconfig > +++ b/drivers/media/platform/chips-media/wave5/Kconfig > @@ -1,7 +1,8 @@ > # SPDX-License-Identifier: GPL-2.0 > config VIDEO_WAVE_VPU > tristate "Chips&Media Wave Codec Driver" > - depends on VIDEO_DEV > + depends on V4L_MEM2MEM_DRIVERS > + depends on VIDEO_DEV && OF > select VIDEOBUF2_DMA_CONTIG > select VIDEOBUF2_VMALLOC > select V4L2_MEM2MEM_DEV > > base-commit: b17289d8fcd5c5fe59118586256682ffc5d2fbaf Thank you for the patch. Note for the future: fill in the commit log next time :-) The checkpatch script failed on that, always remember to run that! I added a commit message myself this time since I wanted to get this warning fixed, so no need for a v2, it's now merged. Regards, Hans
diff --git a/drivers/media/platform/chips-media/wave5/Kconfig b/drivers/media/platform/chips-media/wave5/Kconfig index a3b949356cd5..77e7ae5c8f35 100644 --- a/drivers/media/platform/chips-media/wave5/Kconfig +++ b/drivers/media/platform/chips-media/wave5/Kconfig @@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 config VIDEO_WAVE_VPU tristate "Chips&Media Wave Codec Driver" - depends on VIDEO_DEV + depends on V4L_MEM2MEM_DRIVERS + depends on VIDEO_DEV && OF select VIDEOBUF2_DMA_CONTIG select VIDEOBUF2_VMALLOC select V4L2_MEM2MEM_DEV
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com> --- Hi Hans, Sorry about that - can you please squash this into the series? Thanks, Deborah drivers/media/platform/chips-media/wave5/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) base-commit: b17289d8fcd5c5fe59118586256682ffc5d2fbaf