mbox series

[RFC,0/2] soundwire: introduce controller ID

Message ID 20231017160933.12624-1-pierre-louis.bossart@linux.intel.com
Headers show
Series soundwire: introduce controller ID | expand

Message

Pierre-Louis Bossart Oct. 17, 2023, 4:09 p.m. UTC
This patchset is an alternate proposal to the solution suggested in
[1], which breaks Intel machine drivers.

The only difference is to use a known controller ID instead of an IDA,
which wouldn't work with the hard-coded device name.

This patchset was tested on Intel and AMD platforms, testing on
Qualcomm platforms is required - hence the RFC status.

[1] https://lore.kernel.org/alsa-devel/20231004130243.493617-1-krzysztof.kozlowski@linaro.org/

Krzysztof Kozlowski (1):
  soundwire: fix initializing sysfs for same devices on different buses

Pierre-Louis Bossart (1):
  soundwire: bus: introduce controller_id

 drivers/soundwire/amd_manager.c     |  8 ++++++++
 drivers/soundwire/bus.c             |  4 ++++
 drivers/soundwire/debugfs.c         |  2 +-
 drivers/soundwire/intel_auxdevice.c |  3 +++
 drivers/soundwire/master.c          |  2 +-
 drivers/soundwire/qcom.c            |  3 +++
 drivers/soundwire/slave.c           | 12 ++++++------
 include/linux/soundwire/sdw.h       |  4 +++-
 sound/soc/intel/boards/sof_sdw.c    |  4 ++--
 9 files changed, 31 insertions(+), 11 deletions(-)

Comments

Srinivas Kandagatla Nov. 23, 2023, 10:50 a.m. UTC | #1
On 17/10/2023 17:09, Pierre-Louis Bossart wrote:
> This patchset is an alternate proposal to the solution suggested in
> [1], which breaks Intel machine drivers.
> 
> The only difference is to use a known controller ID instead of an IDA,
> which wouldn't work with the hard-coded device name.
> 
> This patchset was tested on Intel and AMD platforms, testing on
> Qualcomm platforms is required - hence the RFC status.
> 
> [1] https://lore.kernel.org/alsa-devel/20231004130243.493617-1-krzysztof.kozlowski@linaro.org/

Tested on X13s.

Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


--srini
> 
> Krzysztof Kozlowski (1):
>    soundwire: fix initializing sysfs for same devices on different buses
> 
> Pierre-Louis Bossart (1):
>    soundwire: bus: introduce controller_id
> 
>   drivers/soundwire/amd_manager.c     |  8 ++++++++
>   drivers/soundwire/bus.c             |  4 ++++
>   drivers/soundwire/debugfs.c         |  2 +-
>   drivers/soundwire/intel_auxdevice.c |  3 +++
>   drivers/soundwire/master.c          |  2 +-
>   drivers/soundwire/qcom.c            |  3 +++
>   drivers/soundwire/slave.c           | 12 ++++++------
>   include/linux/soundwire/sdw.h       |  4 +++-
>   sound/soc/intel/boards/sof_sdw.c    |  4 ++--
>   9 files changed, 31 insertions(+), 11 deletions(-)
>
Vinod Koul Nov. 24, 2023, 6:58 a.m. UTC | #2
On Tue, 17 Oct 2023 11:09:31 -0500, Pierre-Louis Bossart wrote:
> This patchset is an alternate proposal to the solution suggested in
> [1], which breaks Intel machine drivers.
> 
> The only difference is to use a known controller ID instead of an IDA,
> which wouldn't work with the hard-coded device name.
> 
> This patchset was tested on Intel and AMD platforms, testing on
> Qualcomm platforms is required - hence the RFC status.
> 
> [...]

Applied, thanks!

[1/2] soundwire: bus: introduce controller_id
      commit: 6543ac13c623f906200dfd3f1c407d8d333b6995
[2/2] soundwire: fix initializing sysfs for same devices on different buses
      commit: 8a8a9ac8a4972ee69d3dd3d1ae43963ae39cee18

Best regards,