diff mbox series

[v4,15/17] dt-bindings: iommu: rockchip: Add Rockchip RK3588

Message ID 20231207080235.652719-1-andyshrk@163.com
State Superseded
Headers show
Series [v4,01/17] drm/rockchip: move output interface related definition to rockchip_drm_drv.h | expand

Commit Message

Andy Yan Dec. 7, 2023, 8:02 a.m. UTC
From: Andy Yan <andy.yan@rock-chips.com>

Add a Rockchip RK3588 compatible

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>

---

Changes in v4:
- Add const for rockchip,rk3588-iommu compatible

 .../devicetree/bindings/iommu/rockchip,iommu.yaml     | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

Heiko Stuebner Dec. 8, 2023, 4:29 p.m. UTC | #1
Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> Add a Rockchip RK3588 compatible
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

In the next iteration, please split this out into a separate patch and send
it to the iommu+dt maintainers.

Supporting the iommus on rk3588 can be realized separately and the
patch needs to go through a separate tree anyway.


Thanks
Heiko
Krzysztof Kozlowski Dec. 8, 2023, 5:47 p.m. UTC | #2
On 07/12/2023 09:02, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> Add a Rockchip RK3588 compatible
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Andy Yan Dec. 9, 2023, 1:26 a.m. UTC | #3
Hi Heiko:

On 12/9/23 00:29, Heiko Stübner wrote:
> Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan:
>> From: Andy Yan <andy.yan@rock-chips.com>
>>
>> Add a Rockchip RK3588 compatible
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> 
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> 
> In the next iteration, please split this out into a separate patch and send
> it to the iommu+dt maintainers.
> 
> Supporting the iommus on rk3588 can be realized separately and the
> patch needs to go through a separate tree anyway.

Okay, I will split this patch out of this vop2 series, does this mean that
I also need to split out the iommu dt node as a separate patch from current
PATCH16 ?
> 
> 
> Thanks
> Heiko
> 
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
index ba9124f721f1..621dde0e45d8 100644
--- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
@@ -19,9 +19,14 @@  description: |+
 
 properties:
   compatible:
-    enum:
-      - rockchip,iommu
-      - rockchip,rk3568-iommu
+    oneOf:
+      - enum:
+          - rockchip,iommu
+          - rockchip,rk3568-iommu
+      - items:
+          - enum:
+              - rockchip,rk3588-iommu
+          - const: rockchip,rk3568-iommu
 
   reg:
     items: