| Message ID | 20231228131617.3411561-1-liujianfeng1994@gmail.com |
|---|---|
| Headers | show |
| Series | Add hantro g1 video decoder support for RK3588 | expand |
Hi, Jianfeng Am 28.12.23 um 14:16 schrieb Jianfeng Liu: > This is the v2 version of this series adding hantro g1 video decoder > support for rk3588. > > Changes in v2: > - Fix alphabetical order in patch1 and patch3 > - Sort device tree node by bus-address > - Drop rk3588_vpu_variant fron v1 because that is exactly the same as rk3568_vpu_variant if the RK3568 and RK3588 variants match, patch [1/3] is not necessary. Just document a additional compatible in a similar way it's being done for rk3188/rk3066 or rk3228/rk3399. If there are ever differences we don't know about yet, a additional variant can still be added in the driver. Alex > - Link to v1: https://lore.kernel.org/all/20231227173911.3295410-1-liujianfeng1994@gmail.com > > Jianfeng Liu (3): > media: verisilicon: Add support for Hantro G1 on RK3588 > arm64: dts: rockchip: Add Hantro G1 VPU support for RK3588 > dt-bindings: media: rockchip-vpu: Add RK3588 compatible > > .../bindings/media/rockchip-vpu.yaml | 1 + > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 20 +++++++++++++++++++ > .../media/platform/verisilicon/hantro_drv.c | 1 + > 3 files changed, 22 insertions(+) >
Hi Alex, On Sat, 30 Dec 2023 10:46:42 +0100, Alex Bee <knaerzche@gmail.com> wrote: >if the RK3568 and RK3588 variants match, patch [1/3] is not necessary. Just >document a additional compatible in a similar way it's being done for >rk3188/rk3066 or rk3228/rk3399. >If there are ever differences we don't know about yet, a additional variant >can still be added in the driver. You are right, this way works. I should have encounted a ccache issue which made me running a devicetree I didn't want. I will drop patch[1/3] and only add devicetree node and dt-binding in v3. Best regards, Jianfeng