| Message ID | 20240125-topic-thermal-v1-1-3c9d4dced138@linaro.org |
|---|---|
| State | Accepted |
| Commit | 8d5d6abf28ae67c0062de9983254f1a5b6964961 |
| Headers | show |
| Series | Assume polling-delay(-passive) = 0 when absent | expand |
On Thu, Jan 25, 2024 at 01:11:15PM +0100, Konrad Dybcio wrote: > Currently, thermal zones associated with providers that have interrupts > for signaling hot/critical trips are required to set a polling-delay > of 0 to indicate no polling. This feels a bit backwards. > > Assume 0 (no polling) when these properties are not defined. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> I think that makes sense. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > --- > Documentation/devicetree/bindings/thermal/thermal-zones.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml > index dbd52620d293..68398e7e8655 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml > +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml > @@ -228,8 +228,6 @@ patternProperties: > additionalProperties: false > > required: > - - polling-delay > - - polling-delay-passive > - thermal-sensors > - trips > > > -- > 2.40.1 >
On Thu, Jan 25, 2024 at 01:11:15PM +0100, Konrad Dybcio wrote: > Currently, thermal zones associated with providers that have interrupts > for signaling hot/critical trips are required to set a polling-delay > of 0 to indicate no polling. This feels a bit backwards. > > Assume 0 (no polling) when these properties are not defined. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by: Bjorn Andersson <andersson@kernel.org> > --- > Documentation/devicetree/bindings/thermal/thermal-zones.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml > index dbd52620d293..68398e7e8655 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml > +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml > @@ -228,8 +228,6 @@ patternProperties: > additionalProperties: false > > required: > - - polling-delay > - - polling-delay-passive > - thermal-sensors > - trips > > > -- > 2.40.1 >
diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml index dbd52620d293..68398e7e8655 100644 --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml @@ -228,8 +228,6 @@ patternProperties: additionalProperties: false required: - - polling-delay - - polling-delay-passive - thermal-sensors - trips
Currently, thermal zones associated with providers that have interrupts for signaling hot/critical trips are required to set a polling-delay of 0 to indicate no polling. This feels a bit backwards. Assume 0 (no polling) when these properties are not defined. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Documentation/devicetree/bindings/thermal/thermal-zones.yaml | 2 -- 1 file changed, 2 deletions(-)