| Message ID | 20240127172155.63624-1-i@rong.moe |
|---|---|
| Headers | show |
| Series | ARM: dts: qcom: msm8974: Add Samsung Galaxy S5 China support | expand |
On 27/01/2024 18:21, Rong Zhang wrote: > Document Samsung Galaxy S5 China (kltechn) as a klte variant based on > msm8974pro. Also including "samsung,klte" in the compatible chain as > kltechn works fine with the klte DTB except for LEDs and WiFi missing. > > Signed-off-by: Rong Zhang <i@rong.moe> > --- This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
On Mon, 2024-01-29 at 09:20 +0100, Krzysztof Kozlowski wrote: > On 27/01/2024 18:21, Rong Zhang wrote: > > Document Samsung Galaxy S5 China (kltechn) as a klte variant based on > > msm8974pro. Also including "samsung,klte" in the compatible chain as > > kltechn works fine with the klte DTB except for LEDs and WiFi missing. > > > > Signed-off-by: Rong Zhang <i@rong.moe> > > --- > > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Sorry for forgetting that. I will check more precisely the next time. > If a tag was not added on purpose, please state why and what changed. I meant not to add your Acked-by because the dt-binding has changed into a different form to make it consistent with the kltechn DTS. I should have stated it but hopefully it's not too late to ask if the new dt-binding is still eligible to receive your ACK. Thanks, Rong
On Mon, 2024-01-29 at 09:22 +0100, Krzysztof Kozlowski wrote: > On 27/01/2024 18:21, Rong Zhang wrote: > > Samsung Galaxy S5 has many variants. Variants that support LTE use klte* > > as their codename. Currently, the only supported one is the one without > > any suffix, namely, klte. It is known that other klte* variants have > > only minor differences compared to klte and can mostly work with the > > klte DTB. > > > > Split the common part into a common DTSI so that it can be imported in > > the DTS of klte and other klte* variants. > > > > Signed-off-by: Rong Zhang <i@rong.moe> > > --- > > .../qcom-msm8974pro-samsung-klte-common.dtsi | 812 +++++++++++++++++ > > .../dts/qcom/qcom-msm8974pro-samsung-klte.dts | 813 +----------------- > > 2 files changed, 818 insertions(+), 807 deletions(-) > > Why code move is not detected? It's difficult to review it. You moved > almost 100% of lines. Please use correct -B/-M/-C arguments when > generating patch and create new one with proper code move. Will do in v3. Thanks, Rong
Samsung Galaxy S5 has many variants. Currently, the only supported one is klte. Samsung Galaxy S5 China (kltechn) is the China edition of klte, and it can mostly work with the klte DTB, with only LEDs and WiFi missing. This patchset splits out the common part of klte DTS into klte-common DTSI, and adds DTS for kltechn by fixing up the GPIO pins for the LEDs and GPIO expander connected by the WiFi module. A "brcm,board-type" property is added into the wifi@1 node of the common DTSI to allow all klte* variants to load the same NVRAM file. Signed-off-by: Rong Zhang <i@rong.moe> --- Changes in v2: - Split out the common part of klte DTS into klte-common DTSI. - Fix dt-binding to make it consistent with kltechn compatible. - Link to v1: https://lore.kernel.org/r/20240121154010.168440-1-i@rong.moe/ --- Rong Zhang (4): ARM: dts: qcom: msm8974: Split out common part of samsung-klte ARM: dts: qcom: msm8974-klte-common: Pin WiFi board type dt-bindings: arm: qcom: Add Samsung Galaxy S5 China (kltechn) ARM: dts: qcom: msm8974: Add DTS for Samsung Galaxy S5 China (kltechn) .../devicetree/bindings/arm/qcom.yaml | 7 + arch/arm/boot/dts/qcom/Makefile | 1 + .../qcom-msm8974pro-samsung-klte-common.dtsi | 818 ++++++++++++++++++ .../dts/qcom/qcom-msm8974pro-samsung-klte.dts | 813 +---------------- .../qcom/qcom-msm8974pro-samsung-kltechn.dts | 16 + 5 files changed, 848 insertions(+), 807 deletions(-) create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-kltechn.dts base-commit: 3a5879d495b226d0404098e3564462d5f1daa33b