| Message ID | 20240226090600.31952-2-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/acpi: Include missing headers | expand |
On Mon, Feb 26, 2024 at 10:05:59AM +0100, Philippe Mathieu-Daudé wrote: > Date: Mon, 26 Feb 2024 10:05:59 +0100 > From: Philippe Mathieu-Daudé <philmd@linaro.org> > Subject: [PATCH v2 1/2] hw/acpi/ich9: Include missing headers > X-Mailer: git-send-email 2.41.0 > > The ICH9LPCPMRegs structure has MemoryRegion and > Notifier fields, so requires the "qemu/notify.h" Just nit ;-) s/requires/it requires/ > and "exec/memory.h" headers. > > However nothing from "hw/acpi/acpi_dev_interface.h" > is required, so reduce its inclusion to hw/acpi/ich9.c > source file where it is used. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > include/hw/acpi/ich9.h | 3 ++- > hw/acpi/ich9.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) Thanks! Reviewed-by: Zhao Liu <zhao1.liu@intel.com> > > diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h > index 2faf7f0cae..215de3c91f 100644 > --- a/include/hw/acpi/ich9.h > +++ b/include/hw/acpi/ich9.h > @@ -21,12 +21,13 @@ > #ifndef HW_ACPI_ICH9_H > #define HW_ACPI_ICH9_H > > +#include "qemu/notify.h" > +#include "exec/memory.h" > #include "hw/acpi/acpi.h" > #include "hw/acpi/cpu_hotplug.h" > #include "hw/acpi/cpu.h" > #include "hw/acpi/pcihp.h" > #include "hw/acpi/memory_hotplug.h" > -#include "hw/acpi/acpi_dev_interface.h" > #include "hw/acpi/ich9_tco.h" > > #define ACPI_PCIHP_ADDR_ICH9 0x0cc0 > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > index 573d032e8e..6205de6046 100644 > --- a/hw/acpi/ich9.c > +++ b/hw/acpi/ich9.c > @@ -34,8 +34,8 @@ > #include "sysemu/reset.h" > #include "sysemu/runstate.h" > #include "hw/acpi/acpi.h" > +#include "hw/acpi/acpi_dev_interface.h" > #include "hw/acpi/ich9_tco.h" > - > #include "hw/southbridge/ich9.h" > #include "hw/mem/pc-dimm.h" > #include "hw/mem/nvdimm.h" > -- > 2.41.0 >
diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h index 2faf7f0cae..215de3c91f 100644 --- a/include/hw/acpi/ich9.h +++ b/include/hw/acpi/ich9.h @@ -21,12 +21,13 @@ #ifndef HW_ACPI_ICH9_H #define HW_ACPI_ICH9_H +#include "qemu/notify.h" +#include "exec/memory.h" #include "hw/acpi/acpi.h" #include "hw/acpi/cpu_hotplug.h" #include "hw/acpi/cpu.h" #include "hw/acpi/pcihp.h" #include "hw/acpi/memory_hotplug.h" -#include "hw/acpi/acpi_dev_interface.h" #include "hw/acpi/ich9_tco.h" #define ACPI_PCIHP_ADDR_ICH9 0x0cc0 diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 573d032e8e..6205de6046 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -34,8 +34,8 @@ #include "sysemu/reset.h" #include "sysemu/runstate.h" #include "hw/acpi/acpi.h" +#include "hw/acpi/acpi_dev_interface.h" #include "hw/acpi/ich9_tco.h" - #include "hw/southbridge/ich9.h" #include "hw/mem/pc-dimm.h" #include "hw/mem/nvdimm.h"
The ICH9LPCPMRegs structure has MemoryRegion and Notifier fields, so requires the "qemu/notify.h" and "exec/memory.h" headers. However nothing from "hw/acpi/acpi_dev_interface.h" is required, so reduce its inclusion to hw/acpi/ich9.c source file where it is used. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/hw/acpi/ich9.h | 3 ++- hw/acpi/ich9.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)