mbox series

[v2,0/3] spi: pxa2xx: Clean up linux/spi/pxa2xx_spi.h

Message ID 20240307170441.3884452-1-andriy.shevchenko@linux.intel.com
Headers show
Series spi: pxa2xx: Clean up linux/spi/pxa2xx_spi.h | expand

Message

Andy Shevchenko March 7, 2024, 5:03 p.m. UTC 
A couple of cleanups against linux/spi/pxa2xx_spi.h.

In v2:
- preserved a comment (Arnd)
- added tag (Arnd)
- added new patch to avoid using unneeded header in soc/pxa/ssp.c

Andy Shevchenko (3):
  spi: pxa2xx: Kill pxa2xx_set_spi_info()
  spi: pxa2xx: Make num_chipselect 8-bit in the struct
    pxa2xx_spi_controller
  spi: pxa2xx: Use proper SSP header in soc/pxa/ssp.c

 arch/arm/mach-pxa/devices.c    | 18 ------------------
 arch/arm/mach-pxa/spitz.c      | 14 +++++++++++++-
 drivers/soc/pxa/ssp.c          |  2 +-
 include/linux/spi/pxa2xx_spi.h | 10 +---------
 4 files changed, 15 insertions(+), 29 deletions(-)

Comments

Andy Shevchenko March 7, 2024, 5:21 p.m. UTC | #1 
On Thu, Mar 07, 2024 at 07:03:15PM +0200, Andy Shevchenko wrote:

...

> +		pd->dev.platform_data = info;

Oops, this won't compile :-)
Arnd Bergmann March 7, 2024, 10:06 p.m. UTC | #2 
On Thu, Mar 7, 2024, at 18:03, Andy Shevchenko wrote:
> There is nothing from pxa2xx_spi.h used by soc/pxa/ssp.c.
> Replace it with pxa2xx_ssp.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>
Andy Shevchenko March 8, 2024, 12:11 p.m. UTC | #3 
On Thu, Mar 07, 2024 at 11:06:00PM +0100, Arnd Bergmann wrote:
> On Thu, Mar 7, 2024, at 18:03, Andy Shevchenko wrote:
> > There is nothing from pxa2xx_spi.h used by soc/pxa/ssp.c.
> > Replace it with pxa2xx_ssp.h.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Thanks. There is a v3.