| Message ID | 20240308162920.46816-4-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | a39111b1cf0864b1782f30f9a1fa65260d057327 |
| Headers | show |
| Series | spi: xilinx: Massage xilinx_spi.h | expand |
On 3/8/24 17:27, Andy Shevchenko wrote: > There is no use for whole 16-bit for the number of chip select pins. > Drop it to 8 bits and reshuffle the data structure layout to avoid > unnecessary paddings. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/linux/spi/xilinx_spi.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h > index 4ba8f53ce570..1b8d984668b6 100644 > --- a/include/linux/spi/xilinx_spi.h > +++ b/include/linux/spi/xilinx_spi.h > @@ -8,17 +8,17 @@ struct spi_board_info; > > /** > * struct xspi_platform_data - Platform data of the Xilinx SPI driver > - * @num_chipselect: Number of chip select by the IP. > - * @bits_per_word: Number of bits per word. > * @devices: Devices to add when the driver is probed. > * @num_devices: Number of devices in the devices array. > + * @num_chipselect: Number of chip select by the IP. > + * @bits_per_word: Number of bits per word. > * @force_irq: If set, forces QSPI transaction requirements. > */ > struct xspi_platform_data { > - u16 num_chipselect; > - u8 bits_per_word; > struct spi_board_info *devices; > u8 num_devices; > + u8 num_chipselect; > + u8 bits_per_word; > bool force_irq; > }; > Reviewed-by: Michal Simek <michal.simek@amd.com> Thanks, Michal
diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h index 4ba8f53ce570..1b8d984668b6 100644 --- a/include/linux/spi/xilinx_spi.h +++ b/include/linux/spi/xilinx_spi.h @@ -8,17 +8,17 @@ struct spi_board_info; /** * struct xspi_platform_data - Platform data of the Xilinx SPI driver - * @num_chipselect: Number of chip select by the IP. - * @bits_per_word: Number of bits per word. * @devices: Devices to add when the driver is probed. * @num_devices: Number of devices in the devices array. + * @num_chipselect: Number of chip select by the IP. + * @bits_per_word: Number of bits per word. * @force_irq: If set, forces QSPI transaction requirements. */ struct xspi_platform_data { - u16 num_chipselect; - u8 bits_per_word; struct spi_board_info *devices; u8 num_devices; + u8 num_chipselect; + u8 bits_per_word; bool force_irq; };
There is no use for whole 16-bit for the number of chip select pins. Drop it to 8 bits and reshuffle the data structure layout to avoid unnecessary paddings. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/spi/xilinx_spi.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)