| Message ID | 20240312154834.26178-13-tzimmermann@suse.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm: Provide fbdev emulation per memory manager | expand |
Hi,
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Hi Am 13.03.24 um 15:03 schrieb Jocelyn Falempe: > Hi, > > Thanks, it looks good to me. > > Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> Thanks. Do you still have access to that broken realtime system? I wonder if this patch makes a difference, as there's now one large memcpy() less. Best regards Thomas
On 18/03/2024 08:56, Thomas Zimmermann wrote: > Hi > > Am 13.03.24 um 15:03 schrieb Jocelyn Falempe: >> Hi, >> >> Thanks, it looks good to me. >> >> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> > > Thanks. Do you still have access to that broken realtime system? I > wonder if this patch makes a difference, as there's now one large > memcpy() less. Hi, Sure, I'll do some latency tests if I can get access to that server again. Best regards, > > Best regards > Thomas >
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c index 573dbe256aa8b..65f2ed18b31c5 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.c +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c @@ -12,7 +12,7 @@ #include <drm/drm_aperture.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_drv.h> -#include <drm/drm_fbdev_generic.h> +#include <drm/drm_fbdev_shmem.h> #include <drm/drm_file.h> #include <drm/drm_ioctl.h> #include <drm/drm_managed.h> @@ -285,7 +285,7 @@ mgag200_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) * FIXME: A 24-bit color depth does not work with 24 bpp on * G200ER. Force 32 bpp. */ - drm_fbdev_generic_setup(dev, 32); + drm_fbdev_shmem_setup(dev, 32); return 0; }
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Dave Airlie <airlied@redhat.com> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Jocelyn Falempe <jfalempe@redhat.com> --- drivers/gpu/drm/mgag200/mgag200_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)