| Message ID | 20240319051413.6956-1-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/tricore/helper: Use correct string format in cpu_tlb_fill() | expand |
+Anton On 19/3/24 06:14, Philippe Mathieu-Daudé wrote: > 'address' got converted from target_ulong to vaddr in commit > 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill"). > Use the corresponding format string to avoid casting. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > target/tricore/helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/tricore/helper.c b/target/tricore/helper.c > index 6d9e80cc0c..76bd226370 100644 > --- a/target/tricore/helper.c > +++ b/target/tricore/helper.c > @@ -76,9 +76,9 @@ bool tricore_cpu_tlb_fill(CPUState *cs, vaddr address, int size, > ret = get_physical_address(env, &physical, &prot, > address, rw, mmu_idx); > > - qemu_log_mask(CPU_LOG_MMU, "%s address=" TARGET_FMT_lx " ret %d physical " > + qemu_log_mask(CPU_LOG_MMU, "%s address=0x%" VADDR_PRIx " ret %d physical " > HWADDR_FMT_plx " prot %d\n", > - __func__, (target_ulong)address, ret, physical, prot); > + __func__, address, ret, physical, prot); > > if (ret == TLBRET_MATCH) { > tlb_set_page(cs, address & TARGET_PAGE_MASK,
On 3/18/24 19:14, Philippe Mathieu-Daudé wrote: > 'address' got converted from target_ulong to vaddr in commit > 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill"). > Use the corresponding format string to avoid casting. > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > target/tricore/helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Tue, Mar 19, 2024 at 06:14:13AM +0100, Philippe Mathieu-Daudé wrote: > 'address' got converted from target_ulong to vaddr in commit > 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill"). > Use the corresponding format string to avoid casting. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > target/tricore/helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Cheers, Bastian
On 19/3/24 06:14, Philippe Mathieu-Daudé wrote: > 'address' got converted from target_ulong to vaddr in commit > 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill"). > Use the corresponding format string to avoid casting. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > target/tricore/helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, patch queued.
diff --git a/target/tricore/helper.c b/target/tricore/helper.c index 6d9e80cc0c..76bd226370 100644 --- a/target/tricore/helper.c +++ b/target/tricore/helper.c @@ -76,9 +76,9 @@ bool tricore_cpu_tlb_fill(CPUState *cs, vaddr address, int size, ret = get_physical_address(env, &physical, &prot, address, rw, mmu_idx); - qemu_log_mask(CPU_LOG_MMU, "%s address=" TARGET_FMT_lx " ret %d physical " + qemu_log_mask(CPU_LOG_MMU, "%s address=0x%" VADDR_PRIx " ret %d physical " HWADDR_FMT_plx " prot %d\n", - __func__, (target_ulong)address, ret, physical, prot); + __func__, address, ret, physical, prot); if (ret == TLBRET_MATCH) { tlb_set_page(cs, address & TARGET_PAGE_MASK,
'address' got converted from target_ulong to vaddr in commit 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill"). Use the corresponding format string to avoid casting. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- target/tricore/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)