mbox series

[v2,0/6] backlight: Remove struct backlight_properties.fb_blank

Message ID 20240319093915.31778-1-tzimmermann@suse.de
Headers show
Series backlight: Remove struct backlight_properties.fb_blank | expand

Message

Thomas Zimmermann March 19, 2024, 9:37 a.m. UTC
The field fb_blank in struct backlight_properties has been marked for
removal. Remove it in favor of the power and state fields.

Patches 1 to 5 prepare several backlight drivers. They remove fb_blank
or replace driver code with existing helpers.

Patch 6 removes fb_blank from backlight core and drivers. This resolves
another dependency between backlight nad fbdev.

v2:
- omap1: replace 'power' with 'enable'
- clarify commit messages

Thomas Zimmermann (6):
  auxdisplay: ht16k33: Replace use of fb_blank with backlight helper
  backlight: omap1: Remove unused struct omap_backlight_config.set_power
  backlight: omap1: Replace FB_BLANK_ states with simple on/off
  fbdev: omap2/omapfb: Replace use of fb_blank with backlight helpers
  staging: fbtft: Remove reference to fb_blank
  backlight: Remove fb_blank from struct backlight_properties

 drivers/auxdisplay/ht16k33.c                  |  7 +--
 drivers/staging/fbtft/fb_ssd1351.c            |  4 +-
 drivers/staging/fbtft/fbtft-core.c            |  5 +-
 drivers/video/backlight/backlight.c           |  2 -
 drivers/video/backlight/mp3309c.c             |  1 -
 drivers/video/backlight/omap1_bl.c            | 47 +++++++------------
 drivers/video/fbdev/atmel_lcdfb.c             |  1 -
 .../omap2/omapfb/displays/panel-dsi-cm.c      |  7 +--
 .../omapfb/displays/panel-sony-acx565akm.c    | 10 +---
 include/linux/backlight.h                     | 25 +---------
 include/linux/platform_data/omap1_bl.h        |  1 -
 11 files changed, 26 insertions(+), 84 deletions(-)

Comments

Lee Jones March 21, 2024, 6:21 p.m. UTC | #1
On Tue, 19 Mar 2024, Thomas Zimmermann wrote:

> The field fb_blank in struct backlight_properties has been marked for
> removal. Remove it in favor of the power and state fields.
> 
> Patches 1 to 5 prepare several backlight drivers. They remove fb_blank
> or replace driver code with existing helpers.
> 
> Patch 6 removes fb_blank from backlight core and drivers. This resolves
> another dependency between backlight nad fbdev.
> 
> v2:
> - omap1: replace 'power' with 'enable'
> - clarify commit messages
> 
> Thomas Zimmermann (6):
>   auxdisplay: ht16k33: Replace use of fb_blank with backlight helper
>   backlight: omap1: Remove unused struct omap_backlight_config.set_power
>   backlight: omap1: Replace FB_BLANK_ states with simple on/off
>   fbdev: omap2/omapfb: Replace use of fb_blank with backlight helpers
>   staging: fbtft: Remove reference to fb_blank
>   backlight: Remove fb_blank from struct backlight_properties
> 
>  drivers/auxdisplay/ht16k33.c                  |  7 +--
>  drivers/staging/fbtft/fb_ssd1351.c            |  4 +-
>  drivers/staging/fbtft/fbtft-core.c            |  5 +-
>  drivers/video/backlight/backlight.c           |  2 -
>  drivers/video/backlight/mp3309c.c             |  1 -
>  drivers/video/backlight/omap1_bl.c            | 47 +++++++------------
>  drivers/video/fbdev/atmel_lcdfb.c             |  1 -
>  .../omap2/omapfb/displays/panel-dsi-cm.c      |  7 +--
>  .../omapfb/displays/panel-sony-acx565akm.c    | 10 +---
>  include/linux/backlight.h                     | 25 +---------
>  include/linux/platform_data/omap1_bl.h        |  1 -
>  11 files changed, 26 insertions(+), 84 deletions(-)

Is everyone okay with this being pushed through Backlight?

I can send out a PR to an immutable branch for others to pull from.
Lee Jones March 27, 2024, 2:40 p.m. UTC | #2
On Tue, 19 Mar 2024 10:37:19 +0100, Thomas Zimmermann wrote:
> The field fb_blank in struct backlight_properties has been marked for
> removal. Remove it in favor of the power and state fields.
> 
> Patches 1 to 5 prepare several backlight drivers. They remove fb_blank
> or replace driver code with existing helpers.
> 
> Patch 6 removes fb_blank from backlight core and drivers. This resolves
> another dependency between backlight nad fbdev.
> 
> [...]

Applied, thanks!

[1/6] auxdisplay: ht16k33: Replace use of fb_blank with backlight helper
      commit: 7f17d16ea8b470e068bf53835bf05a995bc445db
[2/6] backlight: omap1: Remove unused struct omap_backlight_config.set_power
      commit: 06239b0914ad09e3f051f5f36280206f09533622
[3/6] backlight: omap1: Replace FB_BLANK_ states with simple on/off
      commit: c42cf539bed201cb774c65b8963faf7aaf5633f7
[4/6] fbdev: omap2/omapfb: Replace use of fb_blank with backlight helpers
      commit: fa10b6597b12a384357f422bb160d2833d2bba22
[5/6] staging: fbtft: Remove reference to fb_blank
      commit: d126df04320d4d82bc85273b8af89ea0a22565d3
[6/6] backlight: Remove fb_blank from struct backlight_properties
      commit: 95342cdb3f438d378f48e4db188aa217b9b0a66e

--
Lee Jones [李琼斯]
Lee Jones March 27, 2024, 2:41 p.m. UTC | #3
On Wed, 27 Mar 2024, Lee Jones wrote:

> On Tue, 19 Mar 2024 10:37:19 +0100, Thomas Zimmermann wrote:
> > The field fb_blank in struct backlight_properties has been marked for
> > removal. Remove it in favor of the power and state fields.
> > 
> > Patches 1 to 5 prepare several backlight drivers. They remove fb_blank
> > or replace driver code with existing helpers.
> > 
> > Patch 6 removes fb_blank from backlight core and drivers. This resolves
> > another dependency between backlight nad fbdev.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/6] auxdisplay: ht16k33: Replace use of fb_blank with backlight helper
>       commit: 7f17d16ea8b470e068bf53835bf05a995bc445db
> [2/6] backlight: omap1: Remove unused struct omap_backlight_config.set_power
>       commit: 06239b0914ad09e3f051f5f36280206f09533622
> [3/6] backlight: omap1: Replace FB_BLANK_ states with simple on/off
>       commit: c42cf539bed201cb774c65b8963faf7aaf5633f7
> [4/6] fbdev: omap2/omapfb: Replace use of fb_blank with backlight helpers
>       commit: fa10b6597b12a384357f422bb160d2833d2bba22
> [5/6] staging: fbtft: Remove reference to fb_blank
>       commit: d126df04320d4d82bc85273b8af89ea0a22565d3
> [6/6] backlight: Remove fb_blank from struct backlight_properties
>       commit: 95342cdb3f438d378f48e4db188aa217b9b0a66e

Sent for build testing.  I'll report back once complete.