| Message ID | 20240306212413.1850236-1-andi.shyti@kernel.org |
|---|---|
| Headers | show |
| Series | i2c: add zhaoxin i2c controller driver | expand |
Hi Hans, > > Check the changelog for more details. The little adaptation are > > limited to patch 1, 2 and 3. The other patches don't have any > > change. > > > > The series has been applied in i2c/i2c-host-next[*]. > > V9 does not appear to have been applied in i2c/i2c-host-next[*]. So, should > I submit a v10 version? which its structure is: * patch 0-6 is consistent > with v9. * patch 7 is new to fix issues as you mentioned before Thanks, Hans I'm sorry, I forgot to push :-( Please, check now. Andi
Hi Hans, On Fri, Mar 08, 2024 at 09:22:16AM +0800, Hans Hu wrote: > > Check the changelog for more details. The little adaptation are > > limited to patch 1, 2 and 3. The other patches don't have any > > change. > > > > The series has been applied in i2c/i2c-host-next[*]. > > V9 does not appear to have been applied in i2c/i2c-host-next[*]. So, should > I submit a v10 version? which its structure is: * patch 0-6 is consistent > with v9. * patch 7 is new to fix issues as you mentioned before Thanks, Hans I just want to make sure that we have an understanding on this series. Now that the 6.9 merge window is well over, are you planning to resend this series? Thanks, Andi
Hi Andi, > Hi Hans, > > On Fri, Mar 08, 2024 at 09:22:16AM +0800, Hans Hu wrote: >>> Check the changelog for more details. The little adaptation are >>> limited to patch 1, 2 and 3. The other patches don't have any >>> change. >>> >>> The series has been applied in i2c/i2c-host-next[*]. >> V9 does not appear to have been applied in i2c/i2c-host-next[*]. So, should >> I submit a v10 version? which its structure is: * patch 0-6 is consistent >> with v9. * patch 7 is new to fix issues as you mentioned before Thanks, Hans > I just want to make sure that we have an understanding on this > series. > > Now that the 6.9 merge window is well over, are you planning to > resend this series? Yes, I will submit the v10 patch based on the latest i2c/i2c-host-next[*]. Thanks, Hans
Hi Hans, no functional change here, just fixed a rebase conflict. Patch 78c1dbed3652 ("i2c: wmt: Fix an error handling path in wmt_i2c_probe()") from Christophe Jaillet is a fix that has created some conflict with your series. My work here is just to adapt your series to this change. Check the changelog for more details. The little adaptation are limited to patch 1, 2 and 3. The other patches don't have any change. The series has been applied in i2c/i2c-host-next[*]. Thanks, Andi PS I was almost tempted to fix the checkpatch notes, but we have a deal on that ;-) PPS I'm keeping your e-mail structure and sending the series as reply to your PATCH 0 of v8. [*] git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git v8->v9: * In Patch 1 in probe() do not return at the i2c_add_adapter(), but call clk_disable_unprepare() in case of failure. * In Patch 2 fix the conflict when i2c-wmt.c is removed. * In Patch 2 in wmt_i2c_probe() function, call clk_disable_unprepare() in case of failure. While at it, add a comment to explain the reason. * When renaming i2c_dev to i2c, change also the reference in clk_disable_unprepare(). v7->v8: * move per-msg handling to interrupt context * add private struct viai2c_zhaoxin to handle zhaoxin specific things * fixed some other formatting issues Link: https://lore.kernel.org/all/cover.1704440251.git.hanshu-oc@zhaoxin.com/ v6->v7: * adjust the patch sequence * put those renaming related patches in 1 patch file * rename i2c-*-plt.c to i2c-viai2c-*.c * Some other adjustments suggested by Andi For more details, see the comment in each patch please. Link: https://lore.kernel.org/all/cover.1703830854.git.hanshu-oc@zhaoxin.com/ v5->v6: * fix build warnning reported by kernel test robot. Link: https://lore.kernel.org/all/202312291225.cWVt6YF9-lkp@intel.com/ Link: https://lore.kernel.org/all/cover.1703733126.git.hanshu-oc@zhaoxin.com/ v4->v5: * fix 1 build error. Link: https://lore.kernel.org/all/ZYx0VPVmyQhtG+B9@shikoro/1-a.txt Link: https://lore.kernel.org/all/cover.1703647471.git.hanshu-oc@zhaoxin.com/ v3->v4: * Some adjustments as suggested by Wolfram. * rebase patch on top of for-next branch. Link: https://lore.kernel.org/all/cover.1698889581.git.hanshu-oc@zhaoxin.com/ v2->v3: * Split the number of patches from 2 to 12. Make it easier to review. Link: https://lore.kernel.org/all/cover.1691999569.git.hanshu-oc@zhaoxin.com/ v1->v2: * Fixed some bugs I found myself. Link: https://lore.kernel.org/all/cover.1691030850.git.hanshu-oc@zhaoxin.com/ Old version: This patch has already gone through a round of reviews. Compared with the first round, the main difference of this round of patch is the use of i2c-wmt driver. Link: https://lore.kernel.org/all/20230614094858.317652-1-hanshu-oc@zhaoxin.com/ Signed-off-by: Hans Hu <hanshu-oc@zhaoxin.com> Hans Hu (6): i2c: wmt: create wmt_i2c_init for general init i2c: wmt: split out common files i2c: wmt: rename something i2c: wmt: fix a bug when thread blocked i2c: wmt: add platform type VIAI2C_PLAT_WMT i2c: add zhaoxin i2c controller driver MAINTAINERS | 10 +- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 3 + drivers/i2c/busses/i2c-viai2c-common.c | 250 ++++++++++++++ drivers/i2c/busses/i2c-viai2c-common.h | 85 +++++ drivers/i2c/busses/i2c-viai2c-wmt.c | 148 +++++++++ drivers/i2c/busses/i2c-viai2c-zhaoxin.c | 299 +++++++++++++++++ drivers/i2c/busses/i2c-wmt.c | 421 ------------------------ 8 files changed, 804 insertions(+), 422 deletions(-) create mode 100644 drivers/i2c/busses/i2c-viai2c-common.c create mode 100644 drivers/i2c/busses/i2c-viai2c-common.h create mode 100644 drivers/i2c/busses/i2c-viai2c-wmt.c create mode 100644 drivers/i2c/busses/i2c-viai2c-zhaoxin.c delete mode 100644 drivers/i2c/busses/i2c-wmt.c