mbox series

[0/2] HID: i2c-hid: Unify device wake-up logic

Message ID 20240429233924.6453-1-kl@kl.wtf
Headers show
Series HID: i2c-hid: Unify device wake-up logic | expand

Message

Kenny Levinsen April 29, 2024, 11:33 p.m. UTC 
Third time was not the charm[0]. After Dmitry's comment[1], and after
looking some more at the I2C drivers, I have given up on removing the
smbus probe for now. We can always revisit this later if the situation
improves enough, but there are more important things to fix.

Instead, go all in on the address probe with retry and use it for both
initial probe and resume, replacing the previous retry on power on
commands. This gives us consistency and a single place to update and
document.

[0]: https://lore.kernel.org/all/20240426225739.2166-1-kl@kl.wtf/
[1]: https://lore.kernel.org/all/ZixvUNooESC02cJK@google.com/

Comments

Jiri Kosina May 6, 2024, 9:28 p.m. UTC | #1 
On Tue, 30 Apr 2024, Kenny Levinsen wrote:

> Third time was not the charm[0]. After Dmitry's comment[1], and after
> looking some more at the I2C drivers, I have given up on removing the
> smbus probe for now. We can always revisit this later if the situation
> improves enough, but there are more important things to fix.
> 
> Instead, go all in on the address probe with retry and use it for both
> initial probe and resume, replacing the previous retry on power on
> commands. This gives us consistency and a single place to update and
> document.
> 
> [0]: https://lore.kernel.org/all/20240426225739.2166-1-kl@kl.wtf/
> [1]: https://lore.kernel.org/all/ZixvUNooESC02cJK@google.com/

I really apologize for belated response to all this, I've been completely 
swamped for the past two weeks.

This is now queued in hid.git#for-6.10/i2c-hid.

Thanks,