mbox series

[V5,00/10] wifi: ath12k: add MU-MIMO and 160 MHz bandwidth support

Message ID 20240515165231.12114-1-quic_pradeepc@quicinc.com
Headers show
Series wifi: ath12k: add MU-MIMO and 160 MHz bandwidth support | expand

Message

Pradeep Kumar Chitrapu May 15, 2024, 4:52 p.m. UTC 
Add support for
1. enabling MU-MIMO in HE and EHT modes from hardware
2. setting fixed HE rate/GI/LTF
3. 160 MHz bandwidth in HE mode
4. extended NSS bandwidth support

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

changes in v5:
 - Fix column length to 80 in patch 01/10
 - Fix advertises spelling in patch 09/10
 - Fix choosing spelling in patch 10/10

changes in v4:
 - Fix ath12k-check warnings in patch 2/10 and 7/10
 - remove "hostapd" reference in patches 2/10 and 3/10
 - remove redundant prerequisite-patch-id's in cover letter

changes in v3:
 - address review comments for fixing ath12k-check issues.

changes in v2:
 - Amend mac80211 patch description as the patch is not specific
   to AP mode.
 - Amend EHT MU-MIMO patch description to specify future support
   for STA mode.

Pradeep Kumar Chitrapu (10):
  wifi: mac80211: Add EHT UL MU-MIMO flag in ieee80211_bss_conf
  wifi: ath12k: push HE MU-MIMO params to hardware
  wifi: ath12k: push EHT MU-MIMO params to hardware
  wifi: ath12k: move HE MCS mapper to a separate function
  wifi: ath12k: generate rx and tx mcs maps for supported HE mcs
  wifi: ath12k: fix TX and RX MCS rate configurations in HE mode
  wifi: ath12k: add support for setting fixed HE rate/GI/LTF
  wifi: ath12k: clean up 80P80 support
  wifi: ath12k: add support for 160 MHz bandwidth
  wifi: ath12k: add extended NSS bandwidth support for 160 MHz

 drivers/net/wireless/ath/ath12k/core.h |    2 +
 drivers/net/wireless/ath/ath12k/mac.c  | 1052 ++++++++++++++++++++----
 drivers/net/wireless/ath/ath12k/mac.h  |   17 +
 drivers/net/wireless/ath/ath12k/wmi.c  |   24 +-
 drivers/net/wireless/ath/ath12k/wmi.h  |   98 ++-
 include/net/mac80211.h                 |    4 +
 net/mac80211/cfg.c                     |    5 +
 7 files changed, 994 insertions(+), 208 deletions(-)


base-commit: 5b501f801ab443046d5c31881bba21350396e5c5

Comments

Johannes Berg May 15, 2024, 5:45 p.m. UTC | #1 
> + * @eht_80mhz_full_bw_ul_mumimo: does this BSS support the reception (AP) or
> + *	transmission (non-AP STA) of an EHT TB PPDU on an RU that spans the
> + *	entire PPDU bandwidth
> 

I'm really not sure why you insist on neither fixing the documentation
nor the implementation, but I'll say it again (just this once): they
need to match!

johannes
Pradeep Kumar Chitrapu May 15, 2024, 6:13 p.m. UTC | #2 
On 5/15/2024 10:45 AM, Johannes Berg wrote:
> 
>> + * @eht_80mhz_full_bw_ul_mumimo: does this BSS support the reception (AP) or
>> + *	transmission (non-AP STA) of an EHT TB PPDU on an RU that spans the
>> + *	entire PPDU bandwidth
>>
> 
> I'm really not sure why you insist on neither fixing the documentation
> nor the implementation, but I'll say it again (just this once): they
> need to match!
> 
> johannes
Thanks Johannes for clarification..

Apologies for confusion, I was trying to remove 'AP mode' reference in 
commit description after your initial comment, so that it does not 
conflict with eht_80mhz_full_bw_ul_mumimo's description in code. Also 
was trying to replicate "he_full_ul_mumimo"'s comment in code.

Anyways I understood now (hopefully :)) now and fixed it in V6.
Please let me know if you have any other comments.

Thanks
pradeep