| Message ID | 714216496603cd23c18d9d3e1cc52d8ba21e386d.1715224143.git.zhoubinbin@loongson.cn |
|---|---|
| State | New |
| Headers | show |
| Series | Input: psmouse: Introduce PixArt driver | expand |
Hi Binbin, On Wed, May 15, 2024 at 04:58:56PM +0800, Binbin Zhou wrote: > According to the current design of PixArt touchpad hardware and FW, our > single packet data width needs 11 bytes/15 bytes to receive the complete > three-finger/four-finger data in absolute coordinate mode. > Obviously, it exceeds the design of the native driver, and we try to > extend the length of a single data packet to 16. Please fold this into the patch adding PixArt protocol support. There is no need to make this a separate patch. Thanks.
On Thu, May 23, 2024 at 1:30 AM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > Hi Binbin, > > On Wed, May 15, 2024 at 04:58:56PM +0800, Binbin Zhou wrote: > > According to the current design of PixArt touchpad hardware and FW, our > > single packet data width needs 11 bytes/15 bytes to receive the complete > > three-finger/four-finger data in absolute coordinate mode. > > Obviously, it exceeds the design of the native driver, and we try to > > extend the length of a single data packet to 16. > > Please fold this into the patch adding PixArt protocol support. There is > no need to make this a separate patch. Hi Dmitry: Sorry for the late reply. I will do it in my V2 patchset. Thanks. Binbin > > Thanks. > > -- > Dmitry
diff --git a/drivers/input/mouse/psmouse.h b/drivers/input/mouse/psmouse.h index 4d8acfe0d82a..b05c6fbae7e3 100644 --- a/drivers/input/mouse/psmouse.h +++ b/drivers/input/mouse/psmouse.h @@ -94,7 +94,7 @@ struct psmouse { const char *vendor; const char *name; const struct psmouse_protocol *protocol; - unsigned char packet[8]; + unsigned char packet[16]; unsigned char badbyte; unsigned char pktcnt; unsigned char pktsize;
According to the current design of PixArt touchpad hardware and FW, our single packet data width needs 11 bytes/15 bytes to receive the complete three-finger/four-finger data in absolute coordinate mode. Obviously, it exceeds the design of the native driver, and we try to extend the length of a single data packet to 16. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> --- drivers/input/mouse/psmouse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)