| Message ID | 20240612214812.1149019-1-vladimir.zapolskiy@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFT] arm64: dts: qcom: sm8550: Change camcc power domain from MMCX to MXC | expand |
On 6/13/2024 3:18 AM, Vladimir Zapolskiy wrote: > Any attempt to enable titan_top_gdsc on SM8550-QRD fails and produces > an error message that the gdsc is stuck at 'off' state. > > However if MMCX power domain is simply replaced to MXC one, it allows > to turn titan_top_gdsc on successfully, even if MMCX is remained off > according to /sys/kernel/debug/pm_genpd/pm_genpd_summary report. > > Note that at the moment qcom,sm8450-camcc.yaml gives a definite comment > that the supply power domain should be MMCX, and it may be needed in > some certain cases, but at the moment they are not unveiled on SM8550 > platform. > > Fixes: e271b59e39a6 ("arm64: dts: qcom: sm8550: Add camera clock controller") > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > --- Thanks Vladimir for reporting this. I will check on this issue internally and will get back on this. Thanks, Jagadeesh > arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 4234c92aafe3..a429115524a6 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -2754,7 +2754,7 @@ camcc: clock-controller@ade0000 { > <&bi_tcxo_div2>, > <&bi_tcxo_ao_div2>, > <&sleep_clk>; > - power-domains = <&rpmhpd SM8550_MMCX>; > + power-domains = <&rpmhpd SM8550_MXC>; > required-opps = <&rpmhpd_opp_low_svs>; > #clock-cells = <1>; > #reset-cells = <1>;
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 4234c92aafe3..a429115524a6 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2754,7 +2754,7 @@ camcc: clock-controller@ade0000 { <&bi_tcxo_div2>, <&bi_tcxo_ao_div2>, <&sleep_clk>; - power-domains = <&rpmhpd SM8550_MMCX>; + power-domains = <&rpmhpd SM8550_MXC>; required-opps = <&rpmhpd_opp_low_svs>; #clock-cells = <1>; #reset-cells = <1>;
Any attempt to enable titan_top_gdsc on SM8550-QRD fails and produces an error message that the gdsc is stuck at 'off' state. However if MMCX power domain is simply replaced to MXC one, it allows to turn titan_top_gdsc on successfully, even if MMCX is remained off according to /sys/kernel/debug/pm_genpd/pm_genpd_summary report. Note that at the moment qcom,sm8450-camcc.yaml gives a definite comment that the supply power domain should be MMCX, and it may be needed in some certain cases, but at the moment they are not unveiled on SM8550 platform. Fixes: e271b59e39a6 ("arm64: dts: qcom: sm8550: Add camera clock controller") Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)