| Message ID | 20240614030912.10736-2-jiapeng.chong@linux.alibaba.com |
|---|---|
| State | Accepted |
| Commit | b44327ebc1c926e4b55a7721e3d91313fcf188b1 |
| Headers | show |
| Series | crypto: lib - Use swap() in mpi_powm() | expand |
On Fri, Jun 14, 2024 at 11:09:12AM +0800, Jiapeng Chong wrote: > Use existing swap() function rather than duplicating its implementation. > > ./lib/crypto/mpi/mpi-pow.c:211:11-12: WARNING opportunity for swap(). > ./lib/crypto/mpi/mpi-pow.c:239:12-13: WARNING opportunity for swap(). > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9327 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > lib/crypto/mpi/mpi-pow.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) Patch applied. Thanks.
diff --git a/lib/crypto/mpi/mpi-pow.c b/lib/crypto/mpi/mpi-pow.c index 2fd7a46d55ec..67fbd4c2503d 100644 --- a/lib/crypto/mpi/mpi-pow.c +++ b/lib/crypto/mpi/mpi-pow.c @@ -176,7 +176,6 @@ int mpi_powm(MPI res, MPI base, MPI exp, MPI mod) for (;;) { while (c) { - mpi_ptr_t tp; mpi_size_t xsize; /*if (mpihelp_mul_n(xp, rp, rp, rsize) < 0) goto enomem */ @@ -207,9 +206,7 @@ int mpi_powm(MPI res, MPI base, MPI exp, MPI mod) xsize = msize; } - tp = rp; - rp = xp; - xp = tp; + swap(rp, xp); rsize = xsize; if ((mpi_limb_signed_t) e < 0) { @@ -235,9 +232,7 @@ int mpi_powm(MPI res, MPI base, MPI exp, MPI mod) xsize = msize; } - tp = rp; - rp = xp; - xp = tp; + swap(rp, xp); rsize = xsize; } e <<= 1;
Use existing swap() function rather than duplicating its implementation. ./lib/crypto/mpi/mpi-pow.c:211:11-12: WARNING opportunity for swap(). ./lib/crypto/mpi/mpi-pow.c:239:12-13: WARNING opportunity for swap(). Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9327 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- lib/crypto/mpi/mpi-pow.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)