| Message ID | 20240625145418.694476-1-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFC] testing: restore some testing for i686 | expand |
On 25/06/2024 16.54, Alex Bennée wrote: > The commit 4f9a8315e6 (gitlab-ci.d/crossbuilds: Drop the i386 system > emulation job) was a little too aggressive dropping testing for 32 bit > system builds. FWIW: It was necessary at that point in time since we were constantly running out of CI minutes, and that job was one of the jobs that was running for the longest time, consuming lots of CI minutes, while only testing a host environment that hardly anybody uses anymore. But now we've got our own custom runners, so we're not that badly limited in runtime anymore I guess, so it should be ok to re-introduce this job. > Partially revert but using the debian-i686 cross build > images this time as fedora has deprecated the 32 bit stuff. > > Reported-by: Richard Henderson <richard.henderson@linaro.org> > Suggested-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .gitlab-ci.d/crossbuilds.yml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml > index 47bdb99b5b..5ba728f641 100644 > --- a/.gitlab-ci.d/crossbuilds.yml > +++ b/.gitlab-ci.d/crossbuilds.yml > @@ -37,6 +37,16 @@ cross-arm64-kvm-only: > IMAGE: debian-arm64-cross > EXTRA_CONFIGURE_OPTS: --disable-tcg --without-default-features > > +cross-i686-system: > + extends: > + - .cross_system_build_job > + - .cross_test_artifacts > + needs: > + job: i686-debian-cross-container > + variables: > + IMAGE: debian-i686-cross > + MAKE_CHECK_ARGS: check-qtest Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 47bdb99b5b..5ba728f641 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -37,6 +37,16 @@ cross-arm64-kvm-only: IMAGE: debian-arm64-cross EXTRA_CONFIGURE_OPTS: --disable-tcg --without-default-features +cross-i686-system: + extends: + - .cross_system_build_job + - .cross_test_artifacts + needs: + job: i686-debian-cross-container + variables: + IMAGE: debian-i686-cross + MAKE_CHECK_ARGS: check-qtest + cross-i686-user: extends: - .cross_user_build_job
The commit 4f9a8315e6 (gitlab-ci.d/crossbuilds: Drop the i386 system emulation job) was a little too aggressive dropping testing for 32 bit system builds. Partially revert but using the debian-i686 cross build images this time as fedora has deprecated the 32 bit stuff. Reported-by: Richard Henderson <richard.henderson@linaro.org> Suggested-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- .gitlab-ci.d/crossbuilds.yml | 10 ++++++++++ 1 file changed, 10 insertions(+)