diff mbox series

[v2] tty: serial: ma35d1: Add a NULL check for of_node

Message ID 20240614054554.80-1-ychuang570808@gmail.com
State Superseded
Headers show
Series [v2] tty: serial: ma35d1: Add a NULL check for of_node | expand

Commit Message

Jacky Huang June 14, 2024, 5:45 a.m. UTC 
From: Jacky Huang <ychuang3@nuvoton.com>

The pdev->dev.of_node can be NULL if the "serial" node is absent.
Add a NULL check to return an error in such cases.

Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
---
 drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

Comments

Greg KH June 24, 2024, 1:37 p.m. UTC | #1 
On Fri, Jun 14, 2024 at 05:45:54AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
> 
> The pdev->dev.of_node can be NULL if the "serial" node is absent.
> Add a NULL check to return an error in such cases.
> 
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>

You forgot a "Reported-by:" line as Dan did report this to you.

> ---
>  drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Also, no info as to what changed from v1 :(

thanks,

greg k-h
Jacky Huang June 25, 2024, 12:16 a.m. UTC | #2 
Dear Greg,


On 2024/6/24 下午 09:37, Greg KH wrote:
> On Fri, Jun 14, 2024 at 05:45:54AM +0000, Jacky Huang wrote:
>> From: Jacky Huang <ychuang3@nuvoton.com>
>>
>> The pdev->dev.of_node can be NULL if the "serial" node is absent.
>> Add a NULL check to return an error in such cases.
>>
>> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> You forgot a "Reported-by:" line as Dan did report this to you.
>
>> ---
>>   drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
> Also, no info as to what changed from v1 :(
>
> thanks,
>
> greg k-h

I got it. I will add the "Reported-by:" line and version info to the v3 
patch.


Best Regards,
Jacky Huang
diff mbox series

Patch

diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
index 19f0a305cc43..3b4206e815fe 100644
--- a/drivers/tty/serial/ma35d1_serial.c
+++ b/drivers/tty/serial/ma35d1_serial.c
@@ -688,12 +688,13 @@  static int ma35d1serial_probe(struct platform_device *pdev)
 	struct uart_ma35d1_port *up;
 	int ret = 0;
 
-	if (pdev->dev.of_node) {
-		ret = of_alias_get_id(pdev->dev.of_node, "serial");
-		if (ret < 0) {
-			dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
-			return ret;
-		}
+	if (!pdev->dev.of_node)
+		return -ENODEV;
+
+	ret = of_alias_get_id(pdev->dev.of_node, "serial");
+	if (ret < 0) {
+		dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
+		return ret;
 	}
 	up = &ma35d1serial_ports[ret];
 	up->port.line = ret;