mbox series

[0/4] libata/libsas cleanup fixes

Message ID 20240629124210.181537-6-cassel@kernel.org
Headers show
Series libata/libsas cleanup fixes | expand

Message

Niklas Cassel June 29, 2024, 12:42 p.m. UTC
Hello there,

This series takes the patches that are -stable material from this series:
https://lore.kernel.org/linux-ide/20240626180031.4050226-15-cassel@kernel.org/

Changes since series above:
-Fixed minor review comments for the four patches included in the series.
-Picked up tags.


Kind regards,
Niklas


Niklas Cassel (4):
  ata: libata-core: Fix null pointer dereference on error
  ata,scsi: libata-core: Do not leak memory for ata_port struct members
  ata: libata-core: Fix double free on error
  ata: ahci: Clean up sysfs file on error

 drivers/ata/ahci.c                 | 17 ++++++++++++-----
 drivers/ata/libata-core.c          | 29 ++++++++++++++++++-----------
 drivers/scsi/libsas/sas_ata.c      |  2 +-
 drivers/scsi/libsas/sas_discover.c |  2 +-
 include/linux/libata.h             |  1 +
 5 files changed, 33 insertions(+), 18 deletions(-)

Comments

John Garry June 30, 2024, 9:36 a.m. UTC | #1
> 
> Fixes: 633273a3ed1c ("libata-pmp: hook PMP support and enable it")
> Cc:stable@vger.kernel.org
> Reviewed-by: Damien Le Moal<dlemoal@kernel.org>
> Reviewed-by: Hannes Reinecke<hare@suse.de>
> Signed-off-by: Niklas Cassel<cassel@kernel.org>
> ---

Reviewed-by: John Garry <john.g.garry@oracle.com>
Niklas Cassel June 30, 2024, 9:02 p.m. UTC | #2
On Sat, Jun 29, 2024 at 02:42:10PM +0200, Niklas Cassel wrote:
> Hello there,
> 
> This series takes the patches that are -stable material from this series:
> https://lore.kernel.org/linux-ide/20240626180031.4050226-15-cassel@kernel.org/
> 
> Changes since series above:
> -Fixed minor review comments for the four patches included in the series.
> -Picked up tags.
> 
> 
> Kind regards,
> Niklas
> 
> 
> Niklas Cassel (4):
>   ata: libata-core: Fix null pointer dereference on error
>   ata,scsi: libata-core: Do not leak memory for ata_port struct members
>   ata: libata-core: Fix double free on error
>   ata: ahci: Clean up sysfs file on error
> 
>  drivers/ata/ahci.c                 | 17 ++++++++++++-----
>  drivers/ata/libata-core.c          | 29 ++++++++++++++++++-----------
>  drivers/scsi/libsas/sas_ata.c      |  2 +-
>  drivers/scsi/libsas/sas_discover.c |  2 +-
>  include/linux/libata.h             |  1 +
>  5 files changed, 33 insertions(+), 18 deletions(-)

Martin, James,

considering that the libsas change is extremely trivial,
and that the libsas maintainer (John) has added his R-b tag,
I will simply take this via the libata tree.

Please tell me if you have a problem with this, and it will
never happen again. (I would never do this for something that
wasn't extremely trivial.)


Kind regards,
Niklas
Niklas Cassel June 30, 2024, 9:05 p.m. UTC | #3
On Sat, 29 Jun 2024 14:42:10 +0200, Niklas Cassel wrote:
> This series takes the patches that are -stable material from this series:
> https://lore.kernel.org/linux-ide/20240626180031.4050226-15-cassel@kernel.org/
> 
> Changes since series above:
> -Fixed minor review comments for the four patches included in the series.
> -Picked up tags.
> 
> [...]

Applied to libata/linux.git (for-6.10-fixes), thanks!

[1/4] ata: libata-core: Fix null pointer dereference on error
      https://git.kernel.org/libata/linux/c/5d92c7c5
[2/4] ata,scsi: libata-core: Do not leak memory for ata_port struct members
      https://git.kernel.org/libata/linux/c/f6549f53
[3/4] ata: libata-core: Fix double free on error
      https://git.kernel.org/libata/linux/c/ab9e0c52
[4/4] ata: ahci: Clean up sysfs file on error
      https://git.kernel.org/libata/linux/c/eeb25a09

Kind regards,
Niklas
Martin K. Petersen July 3, 2024, 2:37 a.m. UTC | #4
Niklas,

> considering that the libsas change is extremely trivial, and that the
> libsas maintainer (John) has added his R-b tag, I will simply take
> this via the libata tree.

That's fine!